Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rl_dump_pipe MI command. #2421

Merged
merged 1 commit into from
May 25, 2021
Merged

add rl_dump_pipe MI command. #2421

merged 1 commit into from
May 25, 2021

Conversation

swk
Copy link

@swk swk commented Feb 26, 2021

Dump underlying buckets for SBT rate limits.

Dump underlying buckets for SBT rate limits.
@lgtm-com
Copy link

lgtm-com bot commented Feb 26, 2021

This pull request introduces 1 alert when merging 5389a44 into 9dbb0b8 - view on LGTM.com

new alerts:

  • 1 for Local variable hides global variable

@bogdan-iancu
Copy link
Member

Hi @swk , as I understand, this new rl_dump_pipe is just printing the details of the pipe, which, for non-SBT pipes, is the same as done by rl_list right? (the counter value only). If so, maybe we can find a way to merge these 2 functions ?

@bogdan-iancu bogdan-iancu self-assigned this May 24, 2021
@swk
Copy link
Author

swk commented May 24, 2021 via email

@bogdan-iancu bogdan-iancu merged commit fdd0ddb into OpenSIPS:master May 25, 2021
@bogdan-iancu
Copy link
Member

@swk , ok, it makes sense, let's keep them separately for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants