Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: First time contributors content #130

Merged
merged 14 commits into from
Apr 15, 2024

Conversation

DanielaIgRo
Copy link
Contributor

#97
PR about content for the page First Time Contributors

Please add the points or make the corrections if need it

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@DanielaIgRo DanielaIgRo requested a review from xmnlab March 14, 2024 14:19
Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielaIgRo I added some comments there.

I made the comments in the md file because I forgot to use reviewnb XD sorry

in general lines, I think it would be good to add information as well about:

  • pre-commit
    • explain what is pre-commit, how to install that (pre-commit install), and how to run it for all files (pre-commit run --all-files)
  • linter
  • documentation
  • CI
    • what is CI
    • recommend some options: github actions, azure, circleci, travisci
  • unit tests
    • why use unittest
    • recommend some options for unittest: pytest, unittest, hypothesis
  • and it would be nice to mention about project templates for new projects, and mention about scicookie for python projects, and cookicutter

also it is nice to mention something about communication .. I will try to find something for that

pages/blog/first-time-contributors/index.md Outdated Show resolved Hide resolved
pages/blog/first-time-contributors/index.md Outdated Show resolved Hide resolved
pages/blog/first-time-contributors/index.md Outdated Show resolved Hide resolved
pages/blog/first-time-contributors/index.md Show resolved Hide resolved
pages/blog/first-time-contributors/index.md Outdated Show resolved Hide resolved
pages/blog/first-time-contributors/index.md Outdated Show resolved Hide resolved
pages/blog/first-time-contributors/index.md Show resolved Hide resolved
pages/blog/first-time-contributors/index.md Show resolved Hide resolved
@DanielaIgRo DanielaIgRo requested a review from xmnlab March 14, 2024 21:26
@DanielaIgRo
Copy link
Contributor Author

@xmnlab PR ready for a new Review

@xmnlab
Copy link
Member

xmnlab commented Mar 14, 2024

@xmnlab
Copy link
Member

xmnlab commented Mar 14, 2024

merge commit vs rebase

OSL recommend the usage of git rebase

note: git config --global pull.rebase true

@xmnlab
Copy link
Member

xmnlab commented Mar 14, 2024

options for virtual environment:

  • conda/mamba
  • virtualenv
  • pipenv
  • pixi

@DanielaIgRo DanielaIgRo requested a review from xmnlab March 20, 2024 23:48
@DanielaIgRo
Copy link
Contributor Author

@xmnlab it's ready for a new review

@DanielaIgRo
Copy link
Contributor Author

@xmnlab I hope this commit be ok
Is ready for a new review

@DanielaIgRo DanielaIgRo requested a review from xmnlab April 2, 2024 22:36
@xmnlab
Copy link
Member

xmnlab commented Apr 2, 2024

@DanielaIgRo your branch is out-of-date, could you rebase it on top of the upstream/main please?

@DanielaIgRo
Copy link
Contributor Author

DanielaIgRo commented Apr 2, 2024 via email

@DanielaIgRo
Copy link
Contributor Author

@xmnlab Ready for a review. Hope the last one hehe

@DanielaIgRo
Copy link
Contributor Author

@xmnlab I forgot the conclusion. Now is done


These key features make ArtBox an great tool for multimedia enthusiasts, content creators, and anyone seeking efficient and user-friendly solutions for multimedia file manipulation. Explore the possibilities with ArtBox and elevate your multimedia processing capabilities.

Key features of ArtBox include capabilities for text-to-audio conversion, YouTube video downloading, musical composition from notes, audio removal from video clips, audio extraction, and merging audio with video files. These functionalities position ArtBox as a pivotal tool for multimedia enthusiasts, content creators, and anyone in need of efficient multimedia processing solutions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielaIgRo I don't thing this change should be in this PR, maybe you included that by mistake

@DanielaIgRo DanielaIgRo requested a review from xmnlab April 9, 2024 14:52
@xmnlab
Copy link
Member

xmnlab commented Apr 15, 2024

@DanielaIgRo , thanks for working on that.

@xmnlab xmnlab merged commit b4c7d23 into OpenScienceLabs:main Apr 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants