Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md should include description of check-in & contribution processes, etc #3

Closed
eliotmiranda opened this issue Jun 17, 2016 · 1 comment
Closed

README.md should include description of check-in & contribution processes, etc #3

eliotmiranda opened this issue Jun 17, 2016 · 1 comment
Labels
documentation

Comments

@eliotmiranda
Copy link
Contributor

README.md does describe the contents of the repository but it is thin on how to interact with the repository at a process level. The README should

  • tell people how the repository is managed (master vs branches etc)
  • tell people how to submit issues with the repository (such as this issue)
  • tell people how to become a member, get promoted to an admin etc.
@rmacnak
Copy link
Member

rmacnak commented Jun 20, 2016

This information should be in a file named CONTRIBUTING.md, which will cause GitHub to a display a link to it whenever anyone creates a pull request.

https://github.com/blog/1184-contributing-guidelines

@timfel timfel closed this as completed in 5052e30 Jun 20, 2016
@smalltalking smalltalking mentioned this issue May 13, 2018
Closed
lukego added a commit to studio/opensmalltalk-vm that referenced this issue Feb 25, 2019
@lukego
Merge pull request OpenSmalltalk#3 from lukego/timeliner-refresh
e8782f4 
timerliner.R: Create visualizations of summary data
@OpenSmalltalk-Bot OpenSmalltalk-Bot mentioned this issue Mar 4, 2019
Open
nicolas-cellier-aka-nice added a commit that referenced this issue Sep 21, 2019
@nicolas-cellier-aka-nice
Minor fix in iOS sound plugin
521c75a 
Two things:
1) according to https://developer.apple.com/documentation/audiotoolbox/kaudioqueueproperty_isrunning
  the property is a UInt32, not  a sqInt (a sqInt can be 64 bits long, thus might be not entirely set)
2) nothing tells that the value is a valid boolean value, only that is running if != 0
  if I compile with -fsanitize=undefined, i get this:

>Process 5149 stopped
>* thread #9, name = 'com.apple.coreaudio.AQClient', stop reason = Invalid bool load
>    frame #0: 0x000000010090b230 libclang_rt.ubsan_osx_dynamic.dylib`__ubsan_on_report
> libclang_rt.ubsan_osx_dynamic.dylib`__ubsan_on_report:
> ->  0x10090b230 <+0>: pushq  %rbp
>    0x10090b231 <+1>: movq   %rsp, %rbp
>    0x10090b234 <+4>: popq   %rbp
>    0x10090b235 <+5>: retq
>Target 0: (Squeak) stopped.
>(lldb) bt
>* thread #9, name = 'com.apple.coreaudio.AQClient', stop reason = Invalid bool load
>  * frame #0: 0x000000010090b230 libclang_rt.ubsan_osx_dynamic.dylib`__ubsan_on_report
>    frame #1: 0x0000000100905f6c libclang_rt.ubsan_osx_dynamic.dylib`__ubsan::Diag::~Diag() + 140
>    frame #2: 0x0000000100909ab9 libclang_rt.ubsan_osx_dynamic.dylib`handleLoadInvalidValue(__ubsan::InvalidValueData*, unsigned long, __ubsan::ReportOptions) + 505
>    frame #3: 0x00000001009098b4 libclang_rt.ubsan_osx_dynamic.dylib`__ubsan_handle_load_invalid_value + 68
>    frame #4: 0x00000001004f36ef Squeak`-[sqSqueakSoundCoreAudio setOutputIsRunning:](self=0x00000001021183a0, _cmd="setOutputIsRunning:", outputIsRunning=110) at sqSqueakSoundCoreAudio.h:0
>    frame #5: 0x00000001004ecc6e Squeak`MyAudioQueuePropertyListener(inUserData=0x00000001021183a0, inAQ=0x000000000141d000, inID=1634824814) at sqSqueakSoundCoreAudio.m:90
 >   frame #6: 0x00007fff412ff0b2 AudioToolbox`ClientAudioQueue::PropertyChanged(unsigned int) + 518
 >   frame #7: 0x00007fff412fed65 AudioToolbox`AQClientCallbackMessageReader::DispatchCallbacks(void const*, unsigned long) + 195
 >   frame #8: 0x00007fff412e6ac5 AudioToolbox`ClientAudioQueue::FetchAndDeliverPendingCallbacks(unsigned int) + 291
 >   frame #9: 0x00007fff412e6921 AudioToolbox`AQCallbackReceiver_CallbackNotificationsAvailable + 121
 >   frame #10: 0x00007fff412e66a5 AudioToolbox`_XCallbackNotificationsAvailable + 33
 >   frame #11: 0x00007fff412e64b2 AudioToolbox`mshMIGPerform + 230
 >   frame #12: 0x00007fff42967f39 CoreFoundation`__CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE1_PERFORM_FUNCTION__ + 41
 >   frame #13: 0x00007fff42967e85 CoreFoundation`__CFRunLoopDoSource1 + 533
 >   frame #14: 0x00007fff4295fa40 CoreFoundation`__CFRunLoopRun + 2848
 >   frame #15: 0x00007fff4295ec93 CoreFoundation`CFRunLoopRunSpecific + 483
 >   frame #16: 0x00007fff412c340a AudioToolbox`GenericRunLoopThread::Entry(void*) + 158

I think it's benign, but let's not depend on UB...
Closed
@OpenSmalltalk-Bot OpenSmalltalk-Bot mentioned this issue Nov 14, 2019
Closed
@OpenSmalltalk-Bot OpenSmalltalk-Bot mentioned this issue Feb 20, 2020
Closed
eliotmiranda pushed a commit that referenced this issue May 1, 2020
@cstes
Merge pull request #3 from OpenSmalltalk/Cog
028d18f 
merge apr 24
@dtlewis290 dtlewis290 mentioned this issue Jan 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rmacnak @fniephaus @eliotmiranda