Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend dcegm interface #101

Merged
merged 14 commits into from
May 27, 2024
Merged

Extend dcegm interface #101

merged 14 commits into from
May 27, 2024

Conversation

MaxBlesch
Copy link
Member

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Base automatically changed from batches to main May 27, 2024 12:48
@MaxBlesch MaxBlesch changed the base branch from main to batches May 27, 2024 14:12
@MaxBlesch MaxBlesch requested a review from segsell May 27, 2024 14:37
Copy link
Member

@segsell segsell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 64.35644% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 95.06%. Comparing base (7355ba6) to head (29387f9).

Files Patch % Lines
src/dcegm/interface.py 45.45% 12 Missing ⚠️
src/dcegm/pre_processing/state_space.py 52.17% 11 Missing ⚠️
src/interface.py 22.22% 7 Missing ⚠️
src/dcegm/interpolation.py 78.57% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           batches     #101      +/-   ##
===========================================
- Coverage    99.15%   95.06%   -4.09%     
===========================================
  Files           23       25       +2     
  Lines          824      871      +47     
===========================================
+ Hits           817      828      +11     
- Misses           7       43      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxBlesch MaxBlesch merged commit 6694e41 into batches May 27, 2024
3 of 4 checks passed
@MaxBlesch MaxBlesch deleted the new_errors branch May 27, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants