Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for R #115

Merged
merged 93 commits into from
Nov 29, 2022
Merged

Prepare for R #115

merged 93 commits into from
Nov 29, 2022

Conversation

hmgaudecker
Copy link
Member

All things from #105, which are not directly related to R.

Purpose: If in the (near) future somebody wants to add an example for Julia / Stata / ?, they will be able to check what changed in #105.

timmens and others added 30 commits January 13, 2022 14:57
…cture.

Only kept Python example for the moment.
Untested, for sure nowhere near a working state.
Harmonize test-suite with cookiecutter-pytask
@hmgaudecker
Copy link
Member Author

Hi @timmens, thanks for all your work! Thought I'd take a quick look but this of course was not enough. If micromamba is recent enough on GHA, I'd hope the above environmental variable should do. However, the way to go seems to be to set up a .mambarc file and point micromamba towards it, not sure how to best do that on GHA... Current failure the same as before, additional warning:

Warning: Unexpected input(s) 'use_lockfiles', valid inputs are ['environment-file', 'environment-name', 'micromamba-version', 'extra-specs', 'channels', 'condarc-file', 'channel-priority', 'cache-downloads', 'cache-downloads-key', 'cache-env', 'cache-env-key', 'log-level', 'installer-url', 'condarc-options', 'post-deinit']

@timmens
Copy link
Member

timmens commented Nov 28, 2022

First of all, sorry for pushing so many commits. But, the tests run now, although the windows tests are extremely slow. The checks still fail because the code coverage is too low.

What I did

I am now running pytest directly instead of using tox. This allows me to create only one testing environment, namely when we call the conda incubator. As you proposed, this could be sped up using micromamba. It seems though, that this is not the bottleneck, as the longest running time occurs inside the pytest call; Most likely when the cookiecutter environment is created inside the test. As we are already using mamba there, I can't think of a quick fix to speed this up further.

@hmgaudecker
Copy link
Member Author

Thanks!!!

Just for me to understand: Code coverage fell because we are running those tests directly via pytest now as compared to previously via tox? Nothing substantively changed I guess?

And since I looked into it: Did you try running in parallel while disabling the lockfile? Runtime doesn|t matter much in the end, though.

@timmens
Copy link
Member

timmens commented Nov 28, 2022

  1. The drop in coverage seems to be a bug. The "uncovered" lines are clearly covered by our tests.
  2. No I did not try disabling the lockfile and running it in parallel.

pre-commit-ci bot and others added 9 commits November 28, 2022 20:59
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.3.0 → v4.4.0](pre-commit/pre-commit-hooks@v4.3.0...v4.4.0)
- [github.com/asottile/pyupgrade: v2.37.1 → v3.2.2](asottile/pyupgrade@v2.37.1...v3.2.2)
- [github.com/asottile/reorder_python_imports: v3.8.1 → v3.9.0](asottile/reorder-python-imports@v3.8.1...v3.9.0)
- [github.com/psf/black: 22.6.0 → 22.10.0](psf/black@22.6.0...22.10.0)
- https://github.com/myint/docformatterhttps://github.com/PyCQA/docformatter
- [github.com/PyCQA/docformatter: v1.3.1 → v1.5.0](PyCQA/docformatter@v1.3.1...v1.5.0)
- [github.com/PyCQA/flake8: 4.0.1 → 6.0.0](PyCQA/flake8@4.0.1...6.0.0)
- [github.com/executablebooks/mdformat: 0.7.14 → 0.7.16](executablebooks/mdformat@0.7.14...0.7.16)
- [github.com/executablebooks/mdformat: 0.7.14 → 0.7.16](executablebooks/mdformat@0.7.14...0.7.16)
- [github.com/codespell-project/codespell: v2.1.0 → v2.2.2](codespell-project/codespell@v2.1.0...v2.2.2)
@hmgaudecker hmgaudecker merged commit 4839e90 into main Nov 29, 2022
@hmgaudecker hmgaudecker deleted the prepare_for_r branch November 29, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants