Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Discussion basis for rework of the general HTML structure and the CSS rules #82
This is a draft for a new HTML and CSS structure without (in a first step) major changes to the look and behaviour of the OpenTTD website. It should not step into competition to the draft of @LordAro in PR #80. Instead it should be a discussion basis to come to a favourable result in the end, that in itself is a proper basis for a later responsive redesing of the website.
This draft is not complete and the changes are separated in smaller portions.
Differences to the draft of @LordAro:
Until now I have no draft for pages/index.html and for the CSS. If you want to have it for comparision of ideas, please ask for it.
So basically, you are changing the page into a HTML5 page :) The page was created 10+ years ago, with the idea to support as many browsers as possible. I guess there are no browsers these days not supporting HTML5 .. so yeah, this sounds like a sane idea to me. I let you and @LordAro battle out which approach is best ;)
What is more relevant for me personally, is the CSS. All those images we have now, makes changes to the website really difficult. Having that all CSS would really help out in moving the website forward. For me that is in a higher priority than changing the HTML.
What would help me out most, if we make a single PR per change or something. That makes reviewing a lot easier, and easier to see what is changing. This slowly improves the website. Of course we should not go overboard with it and do every tiny thing in a PR, but for example @LordAro PR is currently very difficult to review for me.
This is a balancing act btw, and not black/white :) Let me know what you think, and how you see to approach this best!
Tnx a lot!
For me it's more discussing and comparing than competing even in the end I want to complete the work together with the best possible result. :-)
I understand your priorities. IMHO a CSS overhaul should base on a proper … ahem … basis. That's the underlying HTML.
O.k., that sounds reasonable. So we can change i.e. the main structure (
Let's try it. I want to keep this PR open as a discussion thread. I'll start with a overhaul of the
I'm o.k. with it.
As discussed, we split the changes into several PRs. If no one is faster with closing or merging, your opinion is welcome. ;-)