Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion basis for rework of the general HTML structure and the CSS rules #82

Closed
wants to merge 9 commits into from

Conversation

@auge8472
Copy link
Contributor

auge8472 commented Apr 13, 2019

This is a draft for a new HTML and CSS structure without (in a first step) major changes to the look and behaviour of the OpenTTD website. It should not step into competition to the draft of @LordAro in PR #80. Instead it should be a discussion basis to come to a favourable result in the end, that in itself is a proper basis for a later responsive redesing of the website.

This draft is not complete and the changes are separated in smaller portions.

Differences to the draft of @LordAro:

  • The template for the blog entries declares a blog entry as an article instead a section, provides a header (HTML element) for the entry that keeps the articles heading and provides the meta data (date and the authors name) in block elements but not in further headers (these meta data are no headings).
  • The main template follows in general to the changes in #80 but …
    • … stores the download links in the header in a list, …
    • … replaces the class definitions for the current page in the main navigation by a remove of the href-attribute of the link (can be reached with CSS rule a:not([href])) …
    • … and mark-up the page footer as a link list and a paragraph for the copyright note

Until now I have no draft for pages/index.html and for the CSS. If you want to have it for comparision of ideas, please ask for it.

@TrueBrain
Copy link
Member

TrueBrain commented Apr 14, 2019

So basically, you are changing the page into a HTML5 page :) The page was created 10+ years ago, with the idea to support as many browsers as possible. I guess there are no browsers these days not supporting HTML5 .. so yeah, this sounds like a sane idea to me. I let you and @LordAro battle out which approach is best ;)

What is more relevant for me personally, is the CSS. All those images we have now, makes changes to the website really difficult. Having that all CSS would really help out in moving the website forward. For me that is in a higher priority than changing the HTML.

What would help me out most, if we make a single PR per change or something. That makes reviewing a lot easier, and easier to see what is changing. This slowly improves the website. Of course we should not go overboard with it and do every tiny thing in a PR, but for example @LordAro PR is currently very difficult to review for me.

This is a balancing act btw, and not black/white :) Let me know what you think, and how you see to approach this best!

Tnx a lot!

@andythenorth
Copy link
Contributor

andythenorth commented Apr 14, 2019

I am happy to review html / css changes, if you're happy to wait until I get to it :)

@auge8472
Copy link
Contributor Author

auge8472 commented Apr 14, 2019

I let you and @LordAro battle out which approach is best ;)

For me it's more discussing and comparing than competing even in the end I want to complete the work together with the best possible result. :-)

What is more relevant for me personally, is the CSS. … For me that is in a higher priority than changing the HTML.

I understand your priorities. IMHO a CSS overhaul should base on a proper … ahem … basis. That's the underlying HTML.

What would help me out most, if we make a single PR per change or something. That makes reviewing a lot easier, and easier to see what is changing. This slowly improves the website.

O.k., that sounds reasonable. So we can change i.e. the main structure (header, main, footer of the page) without struggling with further corners of the code.

Of course we should not go overboard with it and do every tiny thing in a PR … This is a balancing act btw, and not black/white :)

Let's try it. I want to keep this PR open as a discussion thread. I'll start with a overhaul of the index.php default.html merging @LordAro and my work (HTML and CSS).

… Let me know what you think, and how you see to approach this best!

I'm o.k. with it.

I am happy to review html / css changes, if you're happy to wait until I get to it :)

As discussed, we split the changes into several PRs. If no one is faster with closing or merging, your opinion is welcome. ;-)

@TrueBrain
Copy link
Member

TrueBrain commented Dec 7, 2019

Ping @LordAro : three tickets with near identical suggested changes, but no activity in a long time. What do you want to do with the pull requests?

@auge8472
Copy link
Contributor Author

auge8472 commented Dec 7, 2019

This one was my first attempt that I wanted to stay open for discussion. I made a second attempt with #84 and yes also there was no acitivity for a long time. I'll close this PR.

@auge8472 auge8472 closed this Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.