Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treemap_species table has incorrect native_status field definition #82

Closed
andrewbt opened this issue Mar 12, 2013 · 1 comment
Closed

Comments

@andrewbt
Copy link
Contributor

This potentially affects the speciesimport.py importer as well as the table. From Bob Troester's post on mailing list:

"I noticed in the speciesimport.py code that there are boolean tests for 5 fields in the treemap_species table, but when I looked at the table definition itself* one of those fields, native_status, wasn't marked boolean but char varying(255). If I had populated that field and tried to import it with speciesimport.py the program would have failed with an error message.

When the treemap_species table was created with syncdb(?), it had been initialized with three records, and that native_status field displays "False" or "True" in normal text - clearly not what is wanted. (Also, the native status in these default records for the Maple and Cherry species is given as False - and that must be false!)."

@ahinz
Copy link
Contributor

ahinz commented Jun 3, 2013

This is a major pain for the v1.x series. There were a bunch of fields that were initially mis-typed. Unfortunately that was before we got our hands on it and there are already instances running with this data.

It was decided that it was too dangerous to change that datatype of the field.

More discussion here: #103

In the v2.x series datatypes are not dumb

@ahinz ahinz closed this as completed Jun 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants