New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove annelids from monophyly tests #112

Merged
merged 1 commit into from Sep 29, 2016

Conversation

Projects
None yet
2 participants
@mtholder
Member

mtholder commented Sep 27, 2016

The contesting of annelids by an input to synth 7.0 later appears to be legit. I think we decided that we'd move to a "warnings.csv" for taxa to warn about. I can't recall. w/o this change, propinquity reports an error in the assessments run.

@jar398

This comment has been minimized.

Member

jar398 commented Sep 29, 2016

I think I removed the test because it is not clear what an annelid is, and depending on what you think the circumscription is, the group might actually be monophyletic or not, with evidence both ways. That makes it interesting, but not a very good test of anything.

The issue title suggests that someone thinks that it is a bug (so to speak) that there is no annelid monophyly test. If you think there should be one, can you tell me whether myzostomida is in annelida?

@kcranston kcranston changed the title from no annelids in monophyly tests to remove annelids from monophyly tests Sep 29, 2016

@mtholder

This comment has been minimized.

Member

mtholder commented Sep 29, 2016

sorry for the title confusing you. No, I removed annelids from the test so that the propinquity build would pass. I'm requesting that we merge this to master (for the reasons that you mention about myzostomids)

@jar398

This comment has been minimized.

Member

jar398 commented Sep 29, 2016

Ah. Was reading in gmail and didn't realize this was a PR. I have many updates to inclusions.tsv, made during preparation of OTT 2.10, which include removing the annelid test. I will make a PR for those changes.

@jar398 jar398 merged commit bcb598a into master Sep 29, 2016

@mtholder mtholder referenced this pull request Apr 10, 2018

Open

Annelida #382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment