Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix api docs template #332

Merged
merged 4 commits into from
Sep 12, 2017
Merged

Fix api docs template #332

merged 4 commits into from
Sep 12, 2017

Conversation

Kadee80
Copy link
Contributor

@Kadee80 Kadee80 commented Sep 7, 2017

This PR:

  • Should merge directly to Master
  • Fixes issues with Nav, Footer, and Fonts in docs templates
  • Removes jQuery and SASS from template
  • Removes link to deprecated main site stylesheet (which means we can remove that entire folder and clean up that repository significantly!)
  • Does not touch App or API functionality
  • should resolve issue 285 make docs failing in Travis #285

@Kadee80 Kadee80 requested a review from astaff September 7, 2017 13:50
@coveralls
Copy link

coveralls commented Sep 7, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 90.639% when pulling 5b13357 on fix-api-docs-template into 701c7f4 on master.

@coveralls
Copy link

coveralls commented Sep 7, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 90.639% when pulling 5b13357 on fix-api-docs-template into 701c7f4 on master.

@coveralls
Copy link

coveralls commented Sep 7, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 90.639% when pulling 5b13357 on fix-api-docs-template into 701c7f4 on master.

astaff
astaff reviewed Sep 12, 2017
View reviewed changes
Copy link
Contributor

@astaff astaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm the new code doesn't break anything in Firefox and Edge compared to the current deployment. Once confirmed, go ahead and merge it. Tx!

@Kadee80
Copy link
Contributor Author

Kadee80 commented Sep 12, 2017

RE: Firefox and Edge and Safari, confirmed its fine. This version uses vanilla js and compiled css.

@Kadee80 Kadee80 merged commit 16ba1f8 into master Sep 12, 2017
@mcous mcous deleted the fix-api-docs-template branch November 2, 2017 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astaff astaff astaff left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kadee80 @coveralls @astaff