Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract the production vs development code detection #428

Closed
Martii opened this issue Nov 18, 2014 · 2 comments · Fixed by #429
Closed

Abstract the production vs development code detection #428

Martii opened this issue Nov 18, 2014 · 2 comments · Fixed by #429
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. feature Something we don't already have implemented to the best of knowledge but would like to see.
Milestone
#249

Comments

@Martii
Copy link
Member

Martii commented Nov 18, 2014

This will probably precede most of the other current PRs and affect how some of them operate... so those may need a master merge when implemented.

Applies to #249
@Martii Martii added sooner Sooner would be appreciated. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. feature Something we don't already have implemented to the best of knowledge but would like to see. labels Nov 18, 2014
@Martii Martii self-assigned this Nov 18, 2014
@Martii Martii added this to the #249 milestone Nov 18, 2014
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Nov 18, 2014
Abstract Production vs Development
58a09e5 
* This is pre-approved by sizzle ... insert into every project .js file
* Redirect existing conditionals to use these properties
* The debug library may be improved separately in another issue but needs to and should remain the same property usage
* Manual fix some of the missing/extra semi-colons found thanks to @jerone since in here ... this is probably incomplete and needs another go around
* Manual fix **some** styleguide conformance found by @jerone with missing space
* Remove one of my stale line notes

Tested on dev okay

Closes OpenUserJS#428
@Martii Martii mentioned this issue Nov 18, 2014
Merged
@Zren
Copy link
Contributor

Zren commented Nov 18, 2014

Why was this needed at all?

@Martii
Copy link
Member Author

Martii commented Nov 18, 2014

Already answered in #429

@Martii Martii removed their assignment Nov 18, 2014
@Martii Martii removed the sooner Sooner would be appreciated. label Nov 18, 2014
@Martii Martii mentioned this issue Nov 18, 2014
Merged
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. feature Something we don't already have implemented to the best of knowledge but would like to see.
Milestone
#249
Development

Successfully merging a pull request may close this issue.

Abstract Production vs Development Martii/OpenUserJS.org
2 participants
@Martii @Zren