Move to latest *express* 4 stable #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**NOTES**: * `app.router` is eol'd and is no longer needed. * `aReq.route.params` moved to `aReq.params` * Don't need `app_route` emulation any more
Martii
added
CODE
added 2 commits
November 17, 2014 20:55
Conflicts: controllers/scriptStorage.js Resolved: Favor HEAD
| @@ -33,8 +33,8 @@ if (isPro) { | |||
| }); | |||
| } | |||
|
|
|||
| function getInstallName(aReq) { | |||
| return aReq.route.params.username + '/' + aReq.route.params.scriptname; | |||
| function getInstallName (aReq) { | |||
There was a problem hiding this comment.
Hmmm merge issue here... I didn't do this.
Martii
removed
the
needs testing
|
Approved by sizzle in private... this will be merged sometime tomorrow after a little bit of testing on current deployment of the current head on pro. |
Martii
removed
tracking upstream
|
|
* Unfortunately I don't see an option to keep comments. :\ * Disable minification in `sendMeta` and `sendScript` * Missing in README.md ... added and whoops Applies to OpenUserJS#417
Martii
added
the
PR READY
|
Btw the express-minify failure would have been hidden until production without #428 ;) :) |
Martii
added a commit
that referenced
this pull request
Nov 18, 2014
Move to latest *express* 4 stable Auto-merge... fully retested on dev.
Martii
added
tracking upstream
|
Just to give some assurances for those who are apprehensive about the upgrade... during the unable to deploy time of 8ish days I was constantly on dev testing a lot of things out with express 4... which is another reason why #429 superseded all current PRs including my own... have faith that things will work out for the better especially in this projects only current prolific tester please. :) |
Martii
pushed a commit
to Martii/UserScripts
that referenced
this pull request
Nov 18, 2014
* Add in a layer of protection in case the server errs again ... this script as a Unit Test was fundamentally inclusive in identifying a hidden issue at OpenUserJS/OpenUserJS.org#417 :) * Version bump
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Nov 23, 2014
* Bump requested node to current pro node stable * Rename route to be less cryptic and tiered based for npm functions with alteration of affected controller with handler * Update view to reflect new urls * Squash some deprecation warnings in here since we changed to *express* 4 at OpenUserJS#417
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTES:
app.routeris eol'd and is no longer needed in 4.xaReq.route.paramsmoved toaReq.paramsapp_routeemulation any more@OpenUserJs/admin , @OpenUserJs/backend , @OpenUserJs/frontend , @OpenUserJs/owners :
This needs massive testing in dev please and of course @sizzlemctwizzle approval. Thanks. :)