Issue 232 stored normalization #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 8, 2014 01:01
* Some adherance to STYLEGUIDE.md * Some routine optimization * Additional parameter for `parseMeta` to not clobber a parsed metadata block e.g. not normalized * Default to normalized meta with existing stored Object on S3 * Add normalized flag to all existing `parseMeta` calls Applies to OpenUserJS#232 and eventually OpenUserJS#243 and OpenUserJS#53
* Alphabetize final target * Alphabetize uniques * Add `@icon` to uniques... this should prevent multiple icon values from being downloaded to save user bandwidth Applies to OpenUserJS#232
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Jul 11, 2014
* Moved some code around to accomodate this * Fix undefined variables including one from OpenUserJS#246 if this gets merged in first
sizzlemctwizzle
added a commit
that referenced
this pull request
Jul 11, 2014
Issue 232 stored normalization
|
Check... working. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read commit messages for specifics
Applies to #232 and eventually #242 and #53
Dependencies:
switch#245Tested on dev at this script.