-
Notifications
You must be signed in to change notification settings - Fork 355
Access script source without triggering install count #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… the install count.
|
I took a look at greasyfork's implementation on this as they have awesome looking install counts/graphs. They log every hit up to 15 by ip address. |
|
I consider statistics gathering a low priority at this point (it mostly benefits authors, which is a minority of users), but if working on that interests anyone, I'd be glad to have it. |
Last check was 8 hours max that Chrome/Chromium would allow server side... e.g. I set my cache to 30 days and it still downloaded every 8 hours regardless of setting... but that was a few months back... perhaps they have adhered to web standards?
Yes it would. :) Is the "raw url" going to omit user.js by default with your commit? I'd rather not trigger any user.js engine installer on the URL at all and set the content type to |
Better than serving it up every time like we currently do.
I guess we could use
It'd probably be ignored. Plus I like the symmetry of serving up the raw source similar to libraries. |
User.js with the install button on every page using the incorrect url and not incrementing the install count and messing up automatic updating in each user.js engine with the incorrect url. e.g. the flip side of this coin... the only reason I personally would need this feature is to do a scan of the source code from the homepage I think. If we serve the content at |
You mean someone could write a script to do this? GM accepts any url that ends in |
Yes.
Correct unless someone adds a |
|
Also if you are thinking about this new route to prevent installation counts with actual script source with the header of |
* Some adherance to STYLEGUIDE.md * Some routine optimization * Additional parameter for `parseMeta` to not clobber a parsed metadata block e.g. not normalized * Default to normalized meta with existing stored Object on S3 * Add normalized flag to all existing `parseMeta` calls Applies to OpenUserJS#232 and eventually OpenUserJS#243 and OpenUserJS#53
|
Tested at local dev script with source url of this... did trigger GM installation dialog but doesn't appear to increment so +1 on the advertised feature. :) |
Access script source without triggering install count
* Should cut down on the number of scripts posted to libs that are UserScripts by removing any semblence of install button on main script homepage * Allows raw source to be handled externally... I have been working with portable devices and I can't find any reason to not start out in edit mode with Ace other than this... this makes more logistical sense anyhow imho. * Use empty URI fragment to ensure .user.js engine doesn't trigger install dialog for UserScripts... doesn't matter right now for libraries so omitting... could modify the mime-type but then other feature of updating without install count increment could be affected. Applies to OpenUserJS#150, OpenUserJS#243 and closes OpenUserJS#169
It might be useful to allow access to the script source without triggering the install count. This would discourage people from artificially inflating the install count if they need access to the source for some other reason. I'm weary of people using this instead of uploading their script as a library, but at least this way it won't inflate their install count.
Unrelated thought: we really need to implement cache control for library source (since TM is downloading the source every time its internal cache expires). This is causing more bandwidth usage than it should.