Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2 #65

Merged
merged 33 commits into from
Feb 11, 2014
Merged

Issue 2 #65

merged 33 commits into from
Feb 11, 2014

Conversation

sizzlemctwizzle
Copy link
Member

I just finished integration with GitHub Webhooks so that now when you import a script from GitHub it will be automatically updated on OpenUserJS.org when ever you push changes to the script on the master branch of the repo containing the script. Obviously, this pull request also includes the changes to import scripts from GH.

As per our policy, someone else needs to confirm that this change works before it can be pulled it into master. Webhooks must be world visible so I have the site running on my server at http://site.sizzlemctwizzle.com:7070/ for testing.

Use case:

  1. Put a user script into one of your GitHub repos
  2. Go into the repo settings on GH for the imported script, then Service Hooks, then WebHook URLs
  3. Paste http://site.sizzlemctwizzle.com:7070/github/hook into the URL input box and click the Update settings button
  4. Login to the site (create an account using your GitHub account if you don't have one already) at http://site.sizzlemctwizzle.com:7070/, click on your username, click the edit link, and then click "Manage Scripts"
  5. Click the button to find scripts on GH
  6. Select a user script from the repo with the hook to import and click the load scripts button
  7. You'll be taken to your profile so you can confirm that your script is on the site and installable
  8. Modify the user script locally, commit the change, and then push it to GH
  9. Go to your profile and confirm the the script has been update

sizzlemctwizzle and others added 30 commits November 23, 2013 21:05
…edit page. This won't be the permadent place for this because it takes time to search the repos.
Conflicts:
	controllers/auth.js
Conflicts:
	controllers/auth.js
Forward requests for the script source to the metadata if a special value was past in the "Accept" header, since Greasemonkey merged this requested change.
Only parse metavalues from the actual userscript metadata block.
…ing functionality) implementation of updating scripts automatically via a GitHub WebHook. This completes GitHub integration and closes #2.
…eliable way to do it via S3 except for an explicit existence check which would be overkill.
@sizzlemctwizzle
Copy link
Member Author

This is a very important pull request so I'm going to call @OpenUserJs/backend to please verify this works for you soon so that it can be merged.

@jerone
Copy link
Contributor

jerone commented Feb 10, 2014

I have the site running on my server at http://site.sizzlemctwizzle.com:7070/ for testing

Site offline...?

@sizzlemctwizzle
Copy link
Member Author

Sorry. Should be online now.

@sizzlemctwizzle
Copy link
Member Author

@jerone since you already have a repo with user scripts, you're probably the best person to confirm that this branch works and once you do, hit the "Merge pull request" button.

@sizzlemctwizzle sizzlemctwizzle added this to the 0.1 milestone Feb 11, 2014
@jerone
Copy link
Contributor

jerone commented Feb 11, 2014

@sizzlemctwizzle yeah I tried multiple times, but your sites keeps giving me timeouts. I'll try later today again...

@jerone
Copy link
Contributor

jerone commented Feb 11, 2014

@sizzlemctwizzle yeah I tried multiple times, but your sites keeps giving me timeouts. I'll try later today again...

Keeps erroring:

Firefox can't establish a connection to the server at site.sizzlemctwizzle.com:7070.&f=regular

@sizzlemctwizzle
Copy link
Member Author

@sizzlemctwizzle yeah I tried multiple times, but your sites keeps giving me timeouts. I'll try later today again...

From the error logs it looks like my server lost a connection to the database and then crashed. Sorry.

Anyway, you did confirm that script importing worked for you and I was able to verify that updating scripts via the webhook works for me, so I guess we'll just have to do it live. I wouldn't do this normally but I see no other option. Luckily no one is using the site right now so if it explodes it won't matter and I can just reverse the damage via nodejitsu.

sizzlemctwizzle added a commit that referenced this pull request Feb 11, 2014
Well you did confirm that script importing worked for you and I was able to verify that updating scripts via the webhook works for me, so I guess we'll just have to [do it live](https://www.youtube.com/watch?v=Qy-Y3HJNU_s). I wouldn't do this normally but I see no other option. Luckily no one is using the site right now so if it explodes it won't matter and I can just reverse the damage via nodejitsu.
@sizzlemctwizzle sizzlemctwizzle merged commit 2fd57e8 into master Feb 11, 2014
@sizzlemctwizzle
Copy link
Member Author

Okay, the site is up and I can still login so no functionality lost. However, I tried the find scripts button and it hangs forever since apparently nodejitsu is much slower than my machine. See #66.

This was referenced Feb 11, 2014
@jerone
Copy link
Contributor

jerone commented Feb 11, 2014

so I guess we'll just have to do it live. I wouldn't do this normally but I see no other option. Luckily no one is using the site right now so if it explodes it won't matter and I can just reverse the damage via nodejitsu.

That's no problem. It's an key feature that is needed from the beginning (working or almost working).

@Martii Martii deleted the issue-2 branch August 21, 2014 23:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants