-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 2 #65
Issue 2 #65
Conversation
… GH repo information from the user.
…edit page. This won't be the permadent place for this because it takes time to search the repos.
Conflicts: controllers/auth.js
Conflicts: app.js
Conflicts: controllers/auth.js
Forward requests for the script source to the metadata if a special value was past in the "Accept" header, since Greasemonkey merged this requested change. Only parse metavalues from the actual userscript metadata block.
…ing functionality) implementation of updating scripts automatically via a GitHub WebHook. This completes GitHub integration and closes #2.
…eliable way to do it via S3 except for an explicit existence check which would be overkill.
This is a very important pull request so I'm going to call @OpenUserJs/backend to please verify this works for you soon so that it can be merged. |
Site offline...? |
Sorry. Should be online now. |
@jerone since you already have a repo with user scripts, you're probably the best person to confirm that this branch works and once you do, hit the "Merge pull request" button. |
@sizzlemctwizzle yeah I tried multiple times, but your sites keeps giving me timeouts. I'll try later today again... |
Keeps erroring:
|
From the error logs it looks like my server lost a connection to the database and then crashed. Sorry. Anyway, you did confirm that script importing worked for you and I was able to verify that updating scripts via the webhook works for me, so I guess we'll just have to do it live. I wouldn't do this normally but I see no other option. Luckily no one is using the site right now so if it explodes it won't matter and I can just reverse the damage via nodejitsu. |
Well you did confirm that script importing worked for you and I was able to verify that updating scripts via the webhook works for me, so I guess we'll just have to [do it live](https://www.youtube.com/watch?v=Qy-Y3HJNU_s). I wouldn't do this normally but I see no other option. Luckily no one is using the site right now so if it explodes it won't matter and I can just reverse the damage via nodejitsu.
Okay, the site is up and I can still login so no functionality lost. However, I tried the find scripts button and it hangs forever since apparently nodejitsu is much slower than my machine. See #66. |
That's no problem. It's an key feature that is needed from the beginning (working or almost working). |
I just finished integration with GitHub Webhooks so that now when you import a script from GitHub it will be automatically updated on OpenUserJS.org when ever you push changes to the script on the master branch of the repo containing the script. Obviously, this pull request also includes the changes to import scripts from GH.
As per our policy, someone else needs to confirm that this change works before it can be pulled it into master. Webhooks must be world visible so I have the site running on my server at http://site.sizzlemctwizzle.com:7070/ for testing.
Use case:
http://site.sizzlemctwizzle.com:7070/github/hook
into the URL input box and click the Update settings button