Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: git: configure GHA user name #633

Closed
wants to merge 1 commit into from
Closed

Conversation

uddr
Copy link
Contributor

@uddr uddr commented May 1, 2024

We need to have ability to tag the builds.
Updated release flow tries to tag openvpn-gui
if this tag does not exist.
Before that was done manually.

We need to have ability to tag the builds.
New release flow tries to tag openvpn-gui
if this tag does not exist.
Before that was done manually.

Signed-off-by: Yuriy Darnobyt <yura.darnobyt@openvpn.net>
@uddr uddr requested a review from flichtenheld May 1, 2024 14:06
@uddr uddr mentioned this pull request May 1, 2024
@@ -195,6 +195,9 @@ jobs:
run: |
ln -s vars.example vars
mkdir ../output
# we need to have ability to git tag the versions
# we do not push that tags
git config --global user.name "gha_user"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not enough. Email also needs to be configured. Still fails with fatal: unable to auto-detect email address (got 'runner@fv-az1149-423.(none)')
You need to merge your changes on top of my merge branch and then test the build to see whether it works. Because this only affects master builds and not release/2.6 builds.

@flichtenheld
Copy link
Member

Taking this over since @uddr is on vacation.

@uddr uddr deleted the yuriy/gha-conf-git-user branch June 26, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants