Ability to use temperature and humidity data from another switchbot device for AC #389

[mrlt8]

♻️ Current situation

The current implementation of IR air conditioners uses a default temperature, resulting in inaccurate climate conditions in homekit.

💡 Proposed solution

Use an existing switchbot device with temperature and humidity data as the data source for the AC temperature and humidity.

⚙️ Release Notes

This PR allows the user to select an existing switchbot device for temperature and humidity data for an AC device.

Adds optional meterType and meterId config options to select the relevant device to use for temperature and humidity for the AC device.

If no options are provided or the specified device is not found, the functionality will remain unchanged.

➕ Additional Information

Have only tested with a regular switchbot meter, but should theoretically work with other switchbot devices that support temp/humidity like the hub 2 and WoIOSensor.

[donavanbecker]

Can you rebranch this to the beta-2.6.3 branch?

[mrlt8]

Potentially related issues: #668 #758

[donavanbecker]

@mrlt8 New beta should be released soon. Can you test and verify it works?

[mrlt8]

Yes, can confirm temperature and humidity are available when installing from the beta branch.

One thing I have noticed is that the power status doesn't seem to sync if the device is powered on/off in the switchbot app. Is this a limitation in the switchbot API?

[donavanbecker]

Yes as we get no data back from the api for IR. We can only send commands.

Thanks

[tst-pandit-pan]

Hello there, I wondering if it's possible to link up sensors already in homebridge by others? It would be really helpful if that's possible and the automation will be better, controlling experience will be greater on iOS 17 if this could be added.

I now have a temperature and humidity sensor by Xiaomi and it links to homebridge quite well, it would be awesome to link it with the IR Air Con for a more visualized controlling experience.

Thanks a lot

[donavanbecker]

@tst-pandit-pan That would mean we would have to integrate with another API, which I will not support in this plugin.

[sam-cheuk]

Thank you @donavanbecker & @mrlt8 for all your hard work! The integration of temperature and humidity data into the AC control has been flawless.

I've a suggestion for improvement, it'd be beneficial if the set target temperature could be maintained without resetting to default temperature (i.e. 24°C). Currently, there's no way to indicate what target temperature has been set, as it has been replaced by the sensor temperature.

You may refer from below screenshot, actually I've set the target temperature to 25°C, however, it always shows the default temperature and the sensor temperature.

Expected behavior after improvement

[hamzaahmadk]

@mrlt8 @sam-cheuk could you guys please post your config.json? I'm having issues in getting it to work for me. I have an IR air conditioner and a Hub 2. Thanks!

Here is mine:

            "name": "SwitchBot",
            "credentials": {
                "token": "XXXX",
                "secret": "XXXX",
                "notice": "Keep your Token & Secret a secret!"
            },
            "options": {
                "devices": [
                    {
                        "deviceId": "XXXX",
                        "hide_device": false,
                        "configDeviceType": "Hub 2"
                    }
                ],
                "irdevices": [
                    {
                        "deviceId": "XXXX",
                        "hide_device": false,
                        "configRemoteType": "Air Conditioner",
                        "irair": {
                            "meterType": "Hub 2",
                            "meterId": "XXXX (same as Hub 2 above)"
                        },
                        "external": false
                    }
                ]
            },
            "platform": "SwitchBot"

[sam-cheuk]

@hamzaahmadk is that you need to add a line in AC IR device config?

"connectionType": "OpenAPI"

[hamzaahmadk]

@hamzaahmadk is that you need to add a line in AC IR device config?

"connectionType": "OpenAPI"

Tried it but still no luck 😞

[sam-cheuk]

@hamzaahmadk when I cross checked your config with mine, they're almost the same, except omitting the hide_device and external parameters as their default value is false. I'm using Hub mini + Meter for integrating temperature and humidity data.

Are you able to control your AC via Apple Home or just cannot integrate temperature and humidity data?

[hamzaahmadk]

@sam-cheuk I have been able to fully integrate the AC into Homekit and I can use it there. The problem I am having is that I am getting two temperature values - one actual, and the other which the AC set to. I am using a Hub 2 to both control the devices as well as provide the temperature/humidity readings (which is different to your setup).

I also edited my config.json to remove the hide_device and external parameters to match your config just in case that would make a difference but still no luck.

[mrlt8]

@hamzaahmadk Looks like the integration is updating the temperature of the room where the AC is located as 20.0º - does that match what the hub2 is reporting?

[hamzaahmadk]

@mrlt8 The 20.0º is what the AC is set to and the 23.5º is the temp reported by the Hub 2 (which I have also directly connected to Homekit via Matter). If I understand correctly, in the case of proper integration the temp that the AC is set to (in this case 20.0º) should not show as the current room temperature - only the temp reported by the hub 2 should show. So the temperature should read 23.5º instead of 20.0º–23.5º.

[mrlt8]

correct. can you turn on debug logging for the AC to see if the CurrentTemperature is being set?

[hamzaahmadk]

It looks like the CurrentTemperature is being set to undefined even though it is able to update it on the Hub 2. Here are the relevant lines from the debugging log:

[28/07/2023, 22:09:55] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner device.firmware: undefined
[28/07/2023, 22:09:55] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner this.platform.version: 2.1.1
[28/07/2023, 22:09:55] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner accessory.context.FirmwareRevision: undefined
[28/07/2023, 22:09:55] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner device.firmware: undefined
[28/07/2023, 22:09:55] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner this.platform.version: 2.1.1
[28/07/2023, 22:09:55] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner ValidValues: [0,1,2], hide_automode: undefined, TargetHeaterCoolerState: 1
[28/07/2023, 22:09:55] [@switchbot/homebridge-switchbot] This plugin generated a warning from the characteristic 'Current Relative Humidity': Characteristic not in required or optional characteristic section for service HeaterCooler. Adding anyway.. See https://homebridge.io/w/JtMGR for more info.

[28/07/2023, 22:09:55] [SwitchBot] [DEBUG] Hub 2: Hub 2 AD Using Platform Config Logging: debug
[28/07/2023, 22:09:55] [SwitchBot] [DEBUG] Hub 2: Hub 2 AD Using Platform Config refreshRate: 120
[28/07/2023, 22:09:55] [SwitchBot] [DEBUG] Hub 2: Hub 2 AD Using Default Curtain updateRate: 7
[28/07/2023, 22:09:55] [SwitchBot] [DEBUG] Hub 2: Hub 2 AD openAPIRefreshStatus
[28/07/2023, 22:09:55] [SwitchBot] [DEBUG] Hub 2: Hub 2 AD accessory.context.FirmwareRevision: undefined
[28/07/2023, 22:09:55] [SwitchBot] [DEBUG] Hub 2: Hub 2 AD device.firmware: undefined
[28/07/2023, 22:09:55] [SwitchBot] [DEBUG] Hub 2: Hub 2 AD this.platform.version: 2.1.1
[28/07/2023, 22:09:55] [SwitchBot] [DEBUG] Hub 2: Hub 2 AD accessory.context.FirmwareRevision: undefined
[28/07/2023, 22:09:55] [SwitchBot] [DEBUG] Hub 2: Hub 2 AD device.firmware: undefined
[28/07/2023, 22:09:55] [SwitchBot] [DEBUG] Hub 2: Hub 2 AD this.platform.version: 2.1.1
[28/07/2023, 22:09:55] [SwitchBot] [DEBUG] Hub 2: Hub 2 AD Humidity Sensor Service Not Added
[28/07/2023, 22:09:55] [SwitchBot] [DEBUG] Hub 2: Hub 2 AD Temperature Sensor Service Not Added
[28/07/2023, 22:09:55] [@switchbot/homebridge-switchbot] This plugin generated a warning from the characteristic 'Current Relative Humidity': characteristic value expected valid finite number and received "undefined" (undefined). See https://homebridge.io/w/JtMGR for more info.
[28/07/2023, 22:09:55] [SwitchBot] [DEBUG] Hub 2: Hub 2 AD CurrentRelativeHumidity: undefined
[28/07/2023, 22:09:55] [@switchbot/homebridge-switchbot] This plugin generated a warning from the characteristic 'Current Temperature': characteristic value expected valid finite number and received "undefined" (undefined). See https://homebridge.io/w/JtMGR for more info.

[28/07/2023, 22:09:56] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Get (INACTIVE) CurrentHeaterCoolerState: 0
[28/07/2023, 22:09:56] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Get TargetHeaterCoolerState: 0, ValidValues: 0,1,2
[28/07/2023, 22:09:56] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Using CurrentTemperature from SwitchBot: Hub 2 (C620DBDE04AD)
[28/07/2023, 22:09:56] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Get CurrentTemperature: undefined
[28/07/2023, 22:09:56] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Get RotationSpeed: 4
[28/07/2023, 22:09:56] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Using CurrentRelativeHumidity from SwitchBot: Hub 2 (C620DBDE04AD)
[28/07/2023, 22:09:56] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Get CurrentRelativeHumidity: undefined
[28/07/2023, 22:09:56] [@switchbot/homebridge-switchbot] This plugin generated a warning from the characteristic 'Current Temperature': characteristic value expected valid finite number and received "undefined" (undefined). See https://homebridge.io/w/JtMGR for more info.
[28/07/2023, 22:09:56] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Get HeatingThresholdTemperature: 24
[28/07/2023, 22:09:56] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Get CoolingThresholdTemperature: 24
[28/07/2023, 22:09:56] [@switchbot/homebridge-switchbot] This plugin generated a warning from the characteristic 'Current Relative Humidity': characteristic value expected valid finite number and received "undefined" (undefined). See https://homebridge.io/w/JtMGR for more info.

[28/07/2023, 22:09:57] [SwitchBot] [DEBUG] Hub 2: Hub 2 AD refreshStatus: {"statusCode":100,"body":{"deviceId":"C620DBDE04AD","deviceType":"Hub 2","hubDeviceId":"C620DBDE04AD","humidity":73,"temperature":26.2,"lightLevel":2,"version":"V1.0-0.8"},"message":"success"}
[28/07/2023, 22:09:57] [SwitchBot] [DEBUG] Hub 2: Hub 2 AD openAPIparseStatus
[28/07/2023, 22:09:57] [SwitchBot] update temperature and humidity for Hub 2 AD
[28/07/2023, 22:09:57] [SwitchBot] [DEBUG] Hub 2: Hub 2 AD CurrentRelativeHumidity: 73
[28/07/2023, 22:09:57] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Using CurrentTemperature from SwitchBot: Hub 2 (C620DBDE04AD)
[28/07/2023, 22:09:57] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Get CurrentTemperature: undefined
[28/07/2023, 22:09:57] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Get (INACTIVE) CurrentHeaterCoolerState: 0
[28/07/2023, 22:09:57] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Get RotationSpeed: 4
[28/07/2023, 22:09:57] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Get TargetHeaterCoolerState: 0, ValidValues: 0,1,2
[28/07/2023, 22:09:57] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Get HeatingThresholdTemperature: 24
[28/07/2023, 22:09:57] [@switchbot/homebridge-switchbot] This plugin generated a warning from the characteristic 'Current Temperature': characteristic value expected valid finite number and received "undefined" (undefined). See https://homebridge.io/w/JtMGR for more info.
[28/07/2023, 22:09:57] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Get CoolingThresholdTemperature: 24
[28/07/2023, 22:10:45] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Get (INACTIVE) CurrentHeaterCoolerState: 0
[28/07/2023, 22:10:45] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Get RotationSpeed: 4
[28/07/2023, 22:10:45] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Using CurrentTemperature from SwitchBot: Hub 2 (C620DBDE04AD)
[28/07/2023, 22:10:45] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Get CurrentTemperature: undefined
[28/07/2023, 22:10:45] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Get TargetHeaterCoolerState: 0, ValidValues: 0,1,2
[28/07/2023, 22:10:45] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Get CoolingThresholdTemperature: 24
[28/07/2023, 22:10:45] [SwitchBot] [DEBUG] Air Conditioner: Air Conditioner Get HeatingThresholdTemperature: 24
[28/07/2023, 22:10:45] [@switchbot/homebridge-switchbot] This plugin generated a warning from the characteristic 'Current Temperature': characteristic value expected valid finite number and received "undefined" (undefined). See https://homebridge.io/w/JtMGR for more info.

[mrlt8]

hmm, seems like the hub doesn't update the context.CurrentTemperature/CurrentRelativeHumidity like the meter does?

homebridge-switchbot/src/device/hub.ts

Lines 209 to 213 in f0e3999

	async updateHomeKitCharacteristics(): Promise<void> {
	this.hubHumiditySensor?.updateCharacteristic(this.platform.Characteristic.CurrentRelativeHumidity, this.CurrentRelativeHumidity);
	this.debugLog(`${this.device.deviceType}: ${this.accessory.displayName} CurrentRelativeHumidity: ${this.CurrentRelativeHumidity}`);
	this.hubTemperatureSensor?.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, this.CurrentTemperature);
	}

We could probably get the value using getCharacteristic instead if the hub doesn't update the context? @donavanbecker

[donavanbecker]

@mrlt8 i actually didn't put the hub.ts file together. So we could definitely update it so it works like the others.

[hamzaahmadk]

@mrlt8 Happy to help with testing! 🙂