Increase robustness of XMLDocument parser
#1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xottab-DUTY
reviewed
Nov 11, 2023
Xottab-DUTY
added
Code Quality
Enhancement
Modmaker Experience
AMS21
force-pushed
the
parser/xml_document
branch
from
9b40010
to
eb11467
Compare
|
Implemented suggested changes |
AMS21
force-pushed
the
parser/xml_document
branch
3 times, most recently
from
5c1b613
to
8487911
Compare
|
Left the fuzzer I wrote running last night and it found another problem with a file including itself causing a stack overflow |
- Initialize `m_bIgnoreMissingEndTagError` - Pass down `bool fatal` to `ParseFile`. Previously we would still hit assertions for invalid `#includes` with `fatal` set to `false` - Fix potential use of nullptr when `strstr` returns `nullptr` - Introduce a non failing variant of `r_string` called `try_r_string` - Fix various problems with the handling of `#include`, remove not needed string copy and give feedback on invalid things instead of silently ignoring problems. - Fix an infinite loop in tinyxml when parsing an invalid UTF-8 sequence - Fix infinite recursion or cyclic includes causing a stack overflow
AMS21
force-pushed
the
parser/xml_document
branch
from
8487911
to
c76d36c
Compare
Xottab-DUTY
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
m_bIgnoreMissingEndTagErrorbool fataltoParseFile. Previously we would still hit assertions for invalid#includeswithfatalset tofalsenullptrwhenstrstrreturnsnullptrr_stringcalledtry_r_string#include, remove not needed string copy and give feedback on invalid things instead of silently ignoring problems.