CMake: Use CMAKE_SYSTEM_PROCESSOR instead of ARCH_TYPE variable #1608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by using the
CMAKE_SIZEOF_VOID_P
variable before it is actually set by cmake (after a call to project).https://cmake.org/cmake/help/latest/variable/CMAKE_SIZEOF_VOID_P.html
Also the
else(...)
construct in CMake works a bit different than the original author expected since the expression is not evaluated and thus we always setARCH_TYPE
tox86
which is not correct.Also took the liberty to properly output the
CMAKE_PROJECT_VERSION
and theARCH_TYPE
variables.