CMake: Use CMAKE_SYSTEM_PROCESSOR instead of ARCH_TYPE variable #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was caused by using the `CMAKE_SIZEOF_VOID_P` variable before it is actually set by cmake (after a call to project). https://cmake.org/cmake/help/latest/variable/CMAKE_SIZEOF_VOID_P.html > This is set to the size of a pointer on the target machine, and is > determined when a compiled language is enabled. (...) Also the `else(...)` construct in CMake works a bit different than the original author expected since the expression is not evaluated and thus we always set `ARCH_TYPE` to `x86` which is not correct. Also took the liberty to properly output the `CMAKE_PROJECT_VERSION` and the `ARCH_TYPE` variables.
Xottab-DUTY
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Much thanks!!!
When I was refactoring that part of the code during the creation of 52c3e2e commit, I noticed that ARCH_TYPE was used to set the binaries output folder and CMAKE_SYSTEM_PROCESSOR is better fit there.
But I decided to not touch it yet.
I don't remember why ARCH_TYPE was introduced, but we surely can just remove it.
Xottab-DUTY
changed the title
ARCH_TYPE variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by using the
CMAKE_SIZEOF_VOID_Pvariable before it is actually set by cmake (after a call to project).https://cmake.org/cmake/help/latest/variable/CMAKE_SIZEOF_VOID_P.html
Also the
else(...)construct in CMake works a bit different than the original author expected since the expression is not evaluated and thus we always setARCH_TYPEtox86which is not correct.Also took the liberty to properly output the
CMAKE_PROJECT_VERSIONand theARCH_TYPEvariables.