Fixed xrAICore compilation with LLVM on linux #334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreeZoneMods
requested changes
Jan 26, 2019
| @@ -109,4 +109,6 @@ class CGraphEngine | |||
| #endif | |||
| }; | |||
|
|
|||
| #include "xrAICore/Navigation/PathManagers/path_manager.h" | |||
| #include "xrAICore/Components/problem_solver_inline.h" | |||
There was a problem hiding this comment.
It's not a good idea to remove 'inline' headers from 'base' headers with including 'inline's in different files. The trick with 'inline' headers is used in many places of the engine and your changes may mislead other people. Please try to find a better solution.
P.S. The same changes were suggested in PR #299.
There was a problem hiding this comment.
And I don't remove 'inline' headers from 'base' headers with last commit:
70e5cd5
This was
linked to
issues
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wip on removing inline.h