Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend new ICache #3051

Merged
merged 9 commits into from
Jun 28, 2024
Merged

Frontend new ICache #3051

merged 9 commits into from
Jun 28, 2024

Conversation

ssszwic
Copy link
Member

@ssszwic ssszwic commented Jun 7, 2024

No description provided.

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 94b656c

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
94b656c 1.796 0.453 2.017 1.184 2.923 2.501 2.316 0.929 1.377 1.426 3.414 2.660 2.399 2.959

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
5c5f442 1.827 0.448 2.048 1.190 2.938 2.508 2.289 0.932 1.369 1.410 3.445 2.672 2.398 2.932
d67c873 1.827 0.448 2.048 1.190 2.938 2.508 2.289 0.932 1.369 1.410 3.445 2.672 2.398 2.932
00f9d18 1.809 0.448 2.060 1.191 2.938 2.508 2.290 0.932 1.419 1.338 3.431 2.642 2.398 2.932
3b94d5d 1.809 0.448 2.060 1.191 2.938 2.508 2.290 0.932 1.419 1.338 3.431 2.660 2.398 2.932
2f6c010 1.820 0.448 2.060 1.199 2.938 2.508 2.290 0.932 1.419 1.338 3.427 2.651 2.398 2.932
0f42355 1.820 0.448 2.060 1.199 2.938 2.508 2.290 0.932 1.419 1.338 3.427 2.651 2.398 2.932
95e6033 1.820 0.448 2.060 1.199 2.938 2.508 2.290 0.932 1.419 1.338 3.427 2.651 2.398 2.932
58cb1b0 1.822 0.448 2.060 1.180 2.944 2.503 2.291 0.932 1.419 1.328 3.437 2.644 2.399 2.931
202ef6b 1.815 0.448 2.060 1.182 2.953 2.504 2.291 0.930 1.403 1.319 3.426 2.660 2.397 2.940
4c46d75 1.815 0.448 2.060 1.182 2.953 2.504 2.291 0.930 1.403 1.319 3.426 2.660 2.397 2.940

This was referenced Jun 14, 2024
Merged
Merged
@ngc7331 ngc7331 self-requested a review as a code owner June 19, 2024 02:20
@ngc7331 ngc7331 force-pushed the frontend-newICache branch 2 times, most recently from 6593ecc to 1a28e60 Compare June 19, 2024 02:24
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 6e529e5

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
6e529e5 1.808 0.458 2.006 1.190 2.923 2.501 2.226 0.928 1.351 1.425 3.420 2.659 2.402 2.964

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
c08d352 1.809 0.452 2.052 1.196 2.951 2.499 2.197 0.930 1.377 1.407 3.436 2.653 2.398 2.941
87c5d21 1.805 0.452 2.052 1.196 2.951 2.499 2.199 0.930 1.377 1.407 3.436 2.653 2.398 2.941
864480f 1.809 0.452 2.052 1.196 2.951 2.499 2.199 0.930 1.377 1.407 3.436 2.653 2.398 2.941
69a3c27 1.805 0.452 2.052 1.196 2.951 2.499 2.197 0.930 1.377 1.407 3.436 2.653 2.398 2.941
a31db3f 1.805 0.452 2.052 1.196 2.951 2.499 2.197 0.930 1.377 1.407 3.436 2.653 2.398 2.941
5adc482 1.801 0.452 2.039 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
0d257fb 1.801 0.452 2.040 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
ba5ba1d 1.805 0.452 2.039 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
6613a2d 1.801 0.448 2.040 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
9810c04 1.805 0.448 2.040 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: ad806c3

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
ad806c3 1.808 0.458 2.006 1.190 2.923 2.501 2.226 0.928 1.351 1.425 3.420 2.659 2.402 2.964

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
c08d352 1.809 0.452 2.052 1.196 2.951 2.499 2.197 0.930 1.377 1.407 3.436 2.653 2.398 2.941
87c5d21 1.805 0.452 2.052 1.196 2.951 2.499 2.199 0.930 1.377 1.407 3.436 2.653 2.398 2.941
864480f 1.809 0.452 2.052 1.196 2.951 2.499 2.199 0.930 1.377 1.407 3.436 2.653 2.398 2.941
69a3c27 1.805 0.452 2.052 1.196 2.951 2.499 2.197 0.930 1.377 1.407 3.436 2.653 2.398 2.941
a31db3f 1.805 0.452 2.052 1.196 2.951 2.499 2.197 0.930 1.377 1.407 3.436 2.653 2.398 2.941
5adc482 1.801 0.452 2.039 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
0d257fb 1.801 0.452 2.040 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
ba5ba1d 1.805 0.452 2.039 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
6613a2d 1.801 0.448 2.040 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932
9810c04 1.805 0.448 2.040 1.187 2.936 2.508 2.197 0.930 1.378 1.441 3.428 2.669 2.399 2.932

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: f120d86

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
f120d86 1.808 0.458 2.006 1.190 2.923 2.501 2.226 0.928 1.351 1.425 3.420 2.659 2.402 2.964

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
9134676 1.809 0.451 2.047 1.190 2.940 2.496 2.197 0.932 1.373 1.411 3.181 2.669 2.403 2.948
7ffbf5f 1.809 0.452 2.052 1.196 2.951 2.499 2.199 0.930 1.377 1.407 3.436 2.653 2.398 2.941
d1da158 1.805 0.452 2.052 1.196 2.951 2.499 2.199 0.930 1.377 1.407 3.436 2.653 2.398 2.941
dd40a82 1.809 0.452 2.052 1.196 2.951 2.499 2.199 0.930 1.377 1.407 3.436 2.653 2.398 2.941
2a1dcaf 1.805 0.452 2.052 1.196 2.951 2.499 2.197 0.930 1.377 1.407 3.436 2.653 2.398 2.941
c08d352 1.809 0.452 2.052 1.196 2.951 2.499 2.197 0.930 1.377 1.407 3.436 2.653 2.398 2.941
87c5d21 1.805 0.452 2.052 1.196 2.951 2.499 2.199 0.930 1.377 1.407 3.436 2.653 2.398 2.941
864480f 1.809 0.452 2.052 1.196 2.951 2.499 2.199 0.930 1.377 1.407 3.436 2.653 2.398 2.941
69a3c27 1.805 0.452 2.052 1.196 2.951 2.499 2.197 0.930 1.377 1.407 3.436 2.653 2.398 2.941
a31db3f 1.805 0.452 2.052 1.196 2.951 2.499 2.197 0.930 1.377 1.407 3.436 2.653 2.398 2.941

@ngc7331 ngc7331 added the do not merge Do not merge this pull request label Jun 21, 2024
@ngc7331
Copy link
Collaborator

ngc7331 commented Jun 21, 2024

This PR is ready, but still waiting for feedback from the verification team to tell whether it can be merged to current version.

@eastonman eastonman removed the do not merge Do not merge this pull request label Jun 28, 2024
eastonman
eastonman approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@eastonman eastonman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ICache part is not familiar to me.
IFU & FTQ looks fine.

@Tang-Haojin Tang-Haojin merged commit b92f844 into master Jun 28, 2024
6 checks passed
@Tang-Haojin Tang-Haojin deleted the frontend-newICache branch June 28, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eastonman eastonman eastonman approved these changes

@ngc7331 ngc7331 ngc7331 approved these changes

@Gao-Zeyu Gao-Zeyu Gao-Zeyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ssszwic @XiangShanRobot @ngc7331 @eastonman @Gao-Zeyu @Tang-Haojin