Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add camel support for erc165 #624

Closed
wants to merge 21 commits into from
Closed

Add camel support for erc165 #624

wants to merge 21 commits into from

Conversation

andrew-fleming
Copy link
Collaborator

Fixes (partial) #596

PR Checklist

  • Tests
  • Tried the feature on a public network
  • Documentation

@martriay martriay mentioned this pull request Jun 16, 2023
Merged
@andrew-fleming
Copy link
Collaborator Author

andrew-fleming commented Jun 16, 2023 •
edited

This PR proposes to:

  • Add camelCase tests for ERC165 in test_erc165. Maybe it's overkill? We can remove them if preferred
  • Add an erc165/ directory within introspection/ to help keep things organized
  • Add an introspection/ directory inside of tests/
    • Again, this should help organization as opposed to having a long list of test_<contract>s

Also note, this PR will conflict with #629. It might be easier to merge that first and fix conflicts in this PR after.

Lastly, this follows the design created in #623 by @martriay.

@andrew-fleming andrew-fleming marked this pull request as ready for review June 16, 2023 20:22
@andrew-fleming andrew-fleming marked this pull request as draft June 23, 2023 16:05
@andrew-fleming
Copy link
Collaborator Author

Waiting on #637 to be merged first

@andrew-fleming andrew-fleming mentioned this pull request Jun 23, 2023
Merged
3 tasks
ericnordelo
ericnordelo reviewed Jun 27, 2023
View reviewed changes
src/openzeppelin/introspection/erc165/dual165.cairo Outdated
let snake_selector = constants::SUPPORTS_INTERFACE_SELECTOR;
let camel_selector = constants::SUPPORTSINTERFACE_SELECTOR;
let snake_selector = constants::supports_interface_SELECTOR;
let camel_selector = constants::supportsInterface_SELECTOR;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good readability improvement!

@martriay
Copy link
Contributor

I think this PR got superseded by #637

@martriay martriay closed this Aug 11, 2023
@andrew-fleming andrew-fleming deleted the camel-erc165 branch November 27, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericnordelo ericnordelo ericnordelo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrew-fleming @martriay @ericnordelo