Replace ERC-165 with SRC-5 (Update Interface Ids)

[ericnordelo]

This PR updates the following ids, to the SNIP-5 standard:

Also, replaces ERC165 with SRC5.

• ISRC5_ID

const ISRC5_ID: felt252 = 0x3f918d17e5ee77373b56385708f855659a07f75997f365cf87748628532a055;

// Interface
trait ISRC5 {
    fn supports_interface(interface_id: felt252) -> bool;
}

// Signatures from SNIP-5
[
   'supports_interface(felt252)->E((),())',
]

• IACCOUNT_ID

const IACCOUNT_ID: felt252 = 0x36c738c1c375b993078fe6b517d477e5a3c9b104e40c04662c4bdd3e2f5fa4a;

// Interface
trait IAccount {
    fn __execute__(calls: Array<Call>) -> Array<Span<felt252>>;
    fn __validate__(calls: Array<Call>) -> felt252;
    fn __validate_declare__(class_hash: felt252) -> felt252;
    fn is_valid_signature(message: felt252, signature: Array<felt252>) -> u32;
    fn supports_interface(interface_id: felt252) -> bool;
}

// Signatures from SNIP-5
[
   '__execute__(Array<(ContractAddress,felt252,Array<felt252>)>)->Array<(@Array<felt252>)>',
    '__validate__(Array<(ContractAddress,felt252,Array<felt252>)>)->felt252',
    '__validate_declare__(felt252)->felt252',
    'is_valid_signature(felt252,Array<felt252>)->u32',
    'supports_interface(felt252)->E((),())',
]

• IERC721_ID

const IERC721_ID: felt252 = 0x33eb2f84c309543403fd69f0d0f363781ef06ef6faeb0131ff16ea3175bd943;

// Interface
trait IERC721 {
    fn balance_of(account: ContractAddress) -> u256;
    fn owner_of(token_id: u256) -> ContractAddress;
    fn transfer_from(from: ContractAddress, to: ContractAddress, token_id: u256);
    fn safe_transfer_from(
        from: ContractAddress, to: ContractAddress, token_id: u256, data: Span<felt252>
    );
    fn approve(to: ContractAddress, token_id: u256);
    fn set_approval_for_all(operator: ContractAddress, approved: bool);
    fn get_approved(token_id: u256) -> ContractAddress;
    fn is_approved_for_all(owner: ContractAddress, operator: ContractAddress) -> bool;
}

// Signatures from SNIP-5
[
   "balance_of(ContractAddress)->(u128,u128)",
    "owner_of((u128,u128))->ContractAddress",
    "transfer_from(ContractAddress,ContractAddress,(u128,u128))",
    "safe_transfer_from(ContractAddress,ContractAddress,(u128,u128),(@Array<felt252>))",
    "approve(ContractAddress,(u128,u128))",
    "set_approval_for_all(ContractAddress,E((),()))",
    "get_approved((u128,u128))->ContractAddress",
    "is_approved_for_all(ContractAddress,ContractAddress)->E((),())",
]

• IERC721_RECEIVER_ID

const IERC721_RECEIVER_ID: felt252 = 0x3a0dff5f70d80458ad14ae37bb182a728e3c8cdda0402a5daa86620bdf910bc;

// Interface
trait IERC721Receiver {
    fn on_erc721_received(
        operator: ContractAddress, from: ContractAddress, token_id: u256, data: Span<felt252>
    ) -> felt252;
}

// Signatures from SNIP-5
[
   "on_erc721_received(ContractAddress,ContractAddress,(u128,u128),(@Array<felt252>))->felt252",
]

• IERC721_METADATA_ID

const IERC721_METADATA_ID: felt252 = 0x6069a70848f907fa57668ba1875164eb4dcee693952468581406d131081bbd;

// Interface
trait IERC721Metadata {
    fn name() -> felt252;
    fn symbol() -> felt252;
    fn token_uri(token_id: u256) -> felt252;
}

// Signatures from SNIP-5
[
    "name()->felt252",
    "symbol()->felt252",
    "token_uri((u128,u128))->felt252",
]

• IACCESSCONTROL_ID

const IACCESSCONTROL_ID: felt252 = 0x23700be02858dbe2ac4dc9c9f66d0b6b0ed81ec7f970ca6844500a56ff61751;

// Interface
trait IAccessControl {
    fn has_role(role: felt252, account: ContractAddress) -> bool;
    fn get_role_admin(role: felt252) -> felt252;
    fn grant_role(role: felt252, account: ContractAddress);
    fn revoke_role(role: felt252, account: ContractAddress);
    fn renounce_role(role: felt252, account: ContractAddress);
}

// Signatures from SNIP-5
[
    "has_role(felt252,ContractAddress)->E((),())",
    "get_role_admin(felt252)->felt252",
    "grant_role(felt252,ContractAddress)",
    "revoke_role(felt252,ContractAddress)",
    "renounce_role(felt252,ContractAddress)"
]

• Tests
• Tried the feature on a public network
• Documentation

[andrew-fleming]

Small nitpick, I'd update IACCOUNT_ID in the PR comment because it doesn't match:

const IACCOUNT_ID: felt252 = 0x161ab6ad32c5db670d95c8d430a19024784b4f88b39e4cf2f2cb9b1917fbcd5;

Otherwise, looks good to me!

[martriay]

Looks good! I think we need to remove supports_interface from the Account ID interface (as we're not including it in other interfaces). But I guess that can wait the ad hoc PR we're working on, which is still waiting for design consensus with other account implementers.

[ericnordelo]

I fixed the IAccessControl interface id, after checking interfaces with src5-rs (I had a typo in the signatures :) ).

[andrew-fleming]

Looking good, Eric! I left a small suggestion and question. It otherwise looks ready to me! I also tested the interface ids with src5-rs. Again, excellent work on that :)

[andrew-fleming]

Looks good to me!

[martriay]

looks good to merge! left a final comment

[martriay]

i don't think having this constant duplicated here and in access/accesscontrol.cairo is a good idea. let's keep just one.

[ericnordelo]

Your suggestion is just for AccessControl? All these constants are duplicated, and not a single one is being used from the constant module. Should I remove just AccessControl, or are you suggesting getting rid of the constants module? (at least current contents)

[martriay]

if all constants are already available from their respective modules and no single reference to this module exists (not even in tests) then we should remove it

[ericnordelo]

There is no single reference indeed, but maybe it is better to let this for a separate PR? Even when it is a fairly small change, it will delay things. For example, should we add reference comments in the modules? that's not duplicated.

I can open a different issue and submit the PR removing the constants module if you agree.