Support Cairo 2.5.0 #898
Support Cairo 2.5.0 #898
Conversation
|
|
||
| assert_eq!(x, expected_x); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_secp256k1_serialization() { | ||
| let (big_point_1, big_point_2) = get_points(); | ||
| let curve_size = Secp256k1Impl::get_curve_size(); |
There was a problem hiding this comment.
2.5 issues warnings for unused variables
There was a problem hiding this comment.
yeah, i was a bit more surprised of the unused line, which i believe made it through the audit
| trait UpgradesV1Trait<TState> { | ||
| fn set_value(ref self: TState, val: felt252); | ||
| fn get_value(self: @TState) -> felt252; | ||
| fn remove_selector(self: @TState); | ||
| } | ||
|
|
There was a problem hiding this comment.
why are we removing the traits?
There was a problem hiding this comment.
We were only using the upgrades mock traits to define the v1 and v2 impls, but it seems cleaner to just define impls of the v1 and v2 interfaces
| :eth-account-upgradeable-class-hash: 0x03dda9bcfa854795d91d586b1a4275a68ab1ab185b33a5c00ce647c75875b0ff | ||
| :erc20-class-hash: 0x03af5816946625d3d2c94ea451225715784762050eba736f0b0ad9186685bced | ||
| :erc721-class-hash: 0x045c96d1b24c3dc060680e4bfd4bdc32161aefe8f8939cd4be3954c5d8688d75 | ||
| :account-class-hash: 0x07bb7a849957e721ee9e87e9844cba8ba139e87e671d4c34b17e09829b65134c |
There was a problem hiding this comment.
After merging main the Account hashes changes from using unwrap_syscall instead of unwrap.
I wonder if we shouldn't directly use 2.5.3 in this bump. That would also affect the class hashes.
There was a problem hiding this comment.
Hmm yeah, might as well use 2.5.3. Will update
Fixes #877.
PR Checklist