-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Cairo 2.5.0 #898
Support Cairo 2.5.0 #898
Changes from 7 commits
594a300
a610078
11633bc
6f864a9
26cd094
c5b43cb
4b4e712
0cb5317
9b1b672
974dace
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
// Version | ||
:class-hash-cairo-version: https://crates.io/crates/cairo-lang-compiler/2.4.4[cairo 2.4.4] | ||
:class-hash-cairo-version: https://crates.io/crates/cairo-lang-compiler/2.5.0[cairo 2.5.0] | ||
|
||
// Class Hashes | ||
:account-class-hash: 0x0402765bcede84b1267a9d4658a7737c3c41a8caf6201984c3df95577c2298a3 | ||
:eth-account-upgradeable-class-hash: 0x03dda9bcfa854795d91d586b1a4275a68ab1ab185b33a5c00ce647c75875b0ff | ||
:erc20-class-hash: 0x03af5816946625d3d2c94ea451225715784762050eba736f0b0ad9186685bced | ||
:erc721-class-hash: 0x045c96d1b24c3dc060680e4bfd4bdc32161aefe8f8939cd4be3954c5d8688d75 | ||
:account-class-hash: 0x07bb7a849957e721ee9e87e9844cba8ba139e87e671d4c34b17e09829b65134c | ||
:eth-account-upgradeable-class-hash: 0x02f69cdaf102fe171e57d61e290d37da2098c416bcbb4234abe54d6a330a1a93 | ||
:erc20-class-hash: 0x05f4f6cf4ddd3ad9f6bb57c74f57c225573a669d6c8e1a5c2b3ba29938df44ab | ||
:erc721-class-hash: 0x0715e41c4869448193a910e74f56b3e7535d2c3ce1849bd5fca2ad411c710bd6 | ||
|
||
// Presets page | ||
:presets-page: xref:presets.adoc[Sierra class hash] |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,7 +40,6 @@ fn test_pack_big_secp256k1_points() { | |
#[test] | ||
fn test_unpack_big_secp256k1_points() { | ||
let (big_point_1, big_point_2) = get_points(); | ||
let curve_size = Secp256k1Impl::get_curve_size(); | ||
|
||
// Check point 1 | ||
|
||
|
@@ -54,18 +53,17 @@ fn test_unpack_big_secp256k1_points() { | |
|
||
// Check point 2 | ||
|
||
let (expected_x, expected_y) = big_point_2.get_coordinates().unwrap(); | ||
let (expected_x, _) = big_point_2.get_coordinates().unwrap(); | ||
|
||
let (xlow, xhigh_and_parity) = StorePacking::pack(big_point_2); | ||
let (x, y) = StorePacking::unpack((xlow, xhigh_and_parity)).get_coordinates().unwrap(); | ||
let (x, _) = StorePacking::unpack((xlow, xhigh_and_parity)).get_coordinates().unwrap(); | ||
|
||
assert_eq!(x, expected_x); | ||
} | ||
|
||
#[test] | ||
fn test_secp256k1_serialization() { | ||
let (big_point_1, big_point_2) = get_points(); | ||
let curve_size = Secp256k1Impl::get_curve_size(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. huh There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 2.5 issues warnings for unused variables There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah, i was a bit more surprised of the unused line, which i believe made it through the audit |
||
|
||
let mut serialized_point = array![]; | ||
let mut expected_serialization = array![]; | ||
|
@@ -88,7 +86,6 @@ fn test_secp256k1_serialization() { | |
#[test] | ||
fn test_secp256k1_deserialization() { | ||
let (big_point_1, big_point_2) = get_points(); | ||
let curve_size = Secp256k1Impl::get_curve_size(); | ||
|
||
// Check point 1 | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After merging main the Account hashes changes from using
unwrap_syscall
instead ofunwrap
.I wonder if we shouldn't directly use 2.5.3 in this bump. That would also affect the class hashes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm yeah, might as well use 2.5.3. Will update