Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Hardhat: add development network file to .gitignore #204

Closed
ericglau opened this issue Nov 30, 2022 · 7 comments
Closed

Download Hardhat: add development network file to .gitignore #204

ericglau opened this issue Nov 30, 2022 · 7 comments
Labels
good first issue Good for newcomers

Comments

@ericglau
Copy link
Member

If Download -> Development Package (Hardhat) is used with Upgradeability, add the .openzeppelin/unknown-31337.json file to the resulting .gitignore (so that the development network file for the Hardhat Upgrades Plugin is ignored).

Also consider possibly different naming conventions depending on OpenZeppelin/openzeppelin-upgrades#645

@frangio
Copy link
Contributor

frangio commented Nov 30, 2022

I think you mean OpenZeppelin/openzeppelin-upgrades#465 ?

@ericglau
Copy link
Member Author

Both. If differently named files are written during tests, those should also be ignored.

@frangio
Copy link
Contributor

frangio commented Nov 30, 2022

Yes, though alternatively we should be writing network files in /tmp, which is mentioned in OpenZeppelin/openzeppelin-upgrades#465 as well. In that case there would be nothing to ignore. I think this is the ideal scenario.


Well, that said, for now Wizard should definitely include the current file in .gitignore.

@ericglau ericglau added the good first issue Good for newcomers label Jan 9, 2023
@ericglau
Copy link
Member Author

This is no longer needed due to OpenZeppelin/openzeppelin-upgrades#726, because manifests for Hardhat dev networks will be written under /tmp instead.

@ericglau ericglau closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2023
@aashborn
Copy link

Hi,
But this documentation should be updated to reflect this change, right?: https://docs.openzeppelin.com/upgrades-plugins/1.x/
I had to come across this issue to understand why I can't find the network file at the root of my Hardhat project anymore.

@ericglau
Copy link
Member Author

Hi @aashborn, thanks for pointing this out. We updated https://docs.openzeppelin.com/upgrades-plugins/1.x/network-files#temporary-files but missed that page. Could you please open a new issue?

By the way, could you let us know what is your use case that led you to look for that file for Hardhat?

@aashborn
Copy link

My bad, I had missed this section! I had upgraded to a higher version of Hardhat and I was confused not to see this file anymore🙂

Currently I would just like to use this file to study the variation of the storage layout. I know that this information can also be produced with the compiler options, but as I was saying I also wanted to know why I was not seeing the network file anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants