Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve network file naming #465

Closed
frangio opened this issue Dec 3, 2021 · 2 comments · Fixed by #726
Closed

Improve network file naming #465

frangio opened this issue Dec 3, 2021 · 2 comments · Fixed by #726

Comments

@frangio
Copy link
Contributor

frangio commented Dec 3, 2021

Development networks (Harhdat, Ganache), are named .openzeppelin/unknown-3117.json (or similar). Other "unknown" networks for which we don't have a name get the similarly named files, with the corresponding chain id, even if they're production networks (see #229). This causes a situation where it's not clear which of these files should be gitignored or not.

We can do better for development networks because by inspecting the web3_clientVersion we know it's a dev network if it contains TestRPC, I think.

In that case we should place things in a dedicated directory, possibly even in an ephemeral directory (e.g. /tmp) and we can also go further and try to somehow identify different instances of the test network and use a different file for each, since sharing the same file is a situation that can cause issues (although there are measures in place so that it doesn't).

@fassko
Copy link

fassko commented Feb 16, 2022

This is the same with Polygon Mumbai Testnet.

I was wondering is there a way how to provide the name?

@frangio
Copy link
Contributor Author

frangio commented Feb 17, 2022

@fassko Unfortunately we don't have a way to manually provide the name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants