Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SafeMath test coverage #1386

Closed
nventuro opened this issue Oct 5, 2018 · 1 comment
Closed

Improve SafeMath test coverage #1386

nventuro opened this issue Oct 5, 2018 · 1 comment
Labels
good first issue Low hanging fruit for new contributors to get involved! tests Test suite and helpers.

Comments

@nventuro
Copy link
Contributor

nventuro commented Oct 5, 2018

There are a couple edge cases we should consider adding tests for, to prevent regression errors:

  • div​ with numbers that aren’t divisible evenly
  • div​ with the first argument being 0
  • mul​ with the second argument being 0

Thanks @cwhinfrey and the Level K team for suggesting this!
@nventuro nventuro added kind:improvement tests Test suite and helpers. labels Oct 5, 2018
@nventuro nventuro added this to the v2.1 milestone Oct 5, 2018
@nventuro
Copy link
Contributor Author

nventuro commented Oct 5, 2018

Go ahead @chesnokovilya! I'll gladly review your PR :)

@nventuro nventuro added the good first issue Low hanging fruit for new contributors to get involved! label Oct 8, 2018
Aniket-Engg added a commit to Aniket-Engg/zeppelin-solidity that referenced this issue Oct 23, 2018
@Aniket-Engg
fixes OpenZeppelin#1386
1c70463
@Aniket-Engg Aniket-Engg mentioned this issue Oct 23, 2018
Merged
nventuro pushed a commit that referenced this issue Nov 1, 2018
@Aniket-Engg @nventuro
SafeMath Test Coverage Improved (#1477)
b5892a2 
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a688977.

* updates

* fixes #1404

* approve failing test

* suggested changes done

* ISafeERC20 removed

* conflict fixes

* fixes #1386

* Update SafeMath.test.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Low hanging fruit for new contributors to get involved! tests Test suite and helpers.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nventuro