Dangling commas are now required. #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nventuro
requested review from
come-maiz and
frangio
and removed request for
come-maiz
come-maiz
approved these changes
Sep 29, 2018
Aniket-Engg
added a commit
to Aniket-Engg/zeppelin-solidity
that referenced
this pull request
Oct 1, 2018
This reverts commit a688977.
nventuro
pushed a commit
that referenced
this pull request
Oct 4, 2018
nventuro
pushed a commit
that referenced
this pull request
Oct 8, 2018
* signing prefix added * Minor improvement * Tests changed * Successfully tested * Minor improvements * Minor improvements * Revert "Dangling commas are now required. (#1359)" This reverts commit a688977. * updates * fixes #1384 * introduced claimable and cancelBounty * cancelBounty tests * Update BreakInvariantBounty.test.js
nventuro
pushed a commit
that referenced
this pull request
Oct 9, 2018
nventuro
pushed a commit
that referenced
this pull request
Oct 10, 2018
nventuro
pushed a commit
that referenced
this pull request
Oct 18, 2018
* signing prefix added * Minor improvement * Tests changed * Successfully tested * Minor improvements * Minor improvements * Revert "Dangling commas are now required. (#1359)" This reverts commit a688977. * updates * fixes #1404 * approve failing test * suggested changes done * ISafeERC20 removed * allowance methods in library * Improved SafeERC20 tests. * Fixed test coverage.
nventuro
pushed a commit
to nventuro/openzeppelin-contracts
that referenced
this pull request
Oct 18, 2018
* signing prefix added * Minor improvement * Tests changed * Successfully tested * Minor improvements * Minor improvements * Revert "Dangling commas are now required. (OpenZeppelin#1359)" This reverts commit a688977. * updates * fixes OpenZeppelin#1384 * introduced claimable and cancelBounty * cancelBounty tests * Update BreakInvariantBounty.test.js (cherry picked from commit 41f84f8)
nventuro
pushed a commit
to nventuro/openzeppelin-contracts
that referenced
this pull request
Oct 18, 2018
* signing prefix added * Minor improvement * Tests changed * Successfully tested * Minor improvements * Minor improvements * Revert "Dangling commas are now required. (OpenZeppelin#1359)" This reverts commit a688977. * updates * fixes OpenZeppelin#1392 * event tests added * constructor event added (cherry picked from commit af42c39)
nventuro
pushed a commit
to nventuro/openzeppelin-contracts
that referenced
this pull request
Oct 18, 2018
* signing prefix added * Minor improvement * Tests changed * Successfully tested * Minor improvements * Minor improvements * Revert "Dangling commas are now required. (OpenZeppelin#1359)" This reverts commit a688977. * updates * fixes OpenZeppelin#1206 (cherry picked from commit 58a4244)
come-maiz
pushed a commit
that referenced
this pull request
Oct 21, 2018
(cherry picked from commit a688977)
come-maiz
pushed a commit
that referenced
this pull request
Oct 21, 2018
* signing prefix added * Minor improvement * Tests changed * Successfully tested * Minor improvements * Minor improvements * Revert "Dangling commas are now required. (#1359)" This reverts commit a688977. * fixex #1355 * linting * suggested changes * Update BreakInvariantBounty.test.js (cherry picked from commit 6ae041b)
come-maiz
pushed a commit
that referenced
this pull request
Oct 21, 2018
* signing prefix added * Minor improvement * Tests changed * Successfully tested * Minor improvements * Minor improvements * Revert "Dangling commas are now required. (#1359)" This reverts commit a688977. * updates * fixes #1392 * event tests added * constructor event added (cherry picked from commit af42c39)
come-maiz
pushed a commit
that referenced
this pull request
Oct 21, 2018
* signing prefix added * Minor improvement * Tests changed * Successfully tested * Minor improvements * Minor improvements * Revert "Dangling commas are now required. (#1359)" This reverts commit a688977. * updates * fixes #1404 * approve failing test * suggested changes done * ISafeERC20 removed * allowance methods in library * Improved SafeERC20 tests. * Fixed test coverage. (cherry picked from commit 315f426)
nventuro
pushed a commit
that referenced
this pull request
Nov 1, 2018
…1481) * signing prefix added * Minor improvement * Tests changed * Successfully tested * Minor improvements * Minor improvements * Revert "Dangling commas are now required. (#1359)" This reverts commit a688977. * updates * fixes #1404 * approve failing test * suggested changes done * ISafeERC20 removed * conflict fixes * fixes #1456
nventuro
pushed a commit
that referenced
this pull request
Nov 1, 2018
* signing prefix added * Minor improvement * Tests changed * Successfully tested * Minor improvements * Minor improvements * Revert "Dangling commas are now required. (#1359)" This reverts commit a688977. * updates * fixes #1404 * approve failing test * suggested changes done * ISafeERC20 removed * conflict fixes * fixes #1386 * Update SafeMath.test.js
frangio
pushed a commit
that referenced
this pull request
Dec 5, 2018
* signing prefix added * Minor improvement * Tests changed * Successfully tested * Minor improvements * Minor improvements * Revert "Dangling commas are now required. (#1359)" This reverts commit a688977. * updates * fixes #1404 * approve failing test * suggested changes done * ISafeERC20 removed * conflict fixes * fixes #1512 * Update test/token/ERC721/ERC721Full.test.js Co-Authored-By: Aniket-Engg <30843294+Aniket-Engg@users.noreply.github.com>
nventuro
pushed a commit
that referenced
this pull request
Dec 7, 2018
* signing prefix added * Minor improvement * Tests changed * Successfully tested * Minor improvements * Minor improvements * Revert "Dangling commas are now required. (#1359)" This reverts commit a688977. * updates * fixes #1404 * approve failing test * suggested changes done * ISafeERC20 removed * conflict fixes * fixes #1205 * minor change * suggested changes * reviewed changes * final update
Aniket-Engg
added a commit
to Aniket-Engg/zeppelin-solidity
that referenced
this pull request
Dec 21, 2018
This reverts commit a688977.
frangio
pushed a commit
that referenced
this pull request
Jan 4, 2019
* signing prefix added * Minor improvement * Successfully tested * Minor improvements * Minor improvements * Revert "Dangling commas are now required. (#1359)" This reverts commit a688977. * updates * fixes #1404 * approve failing test * suggested changes done * ISafeERC20 removed * conflict fixes * added examples * fixes #706 * linting * fixes #204 * file fixing * deep bignumber comparison removed * Update SafeERC20Helper.sol * Update IERC20.sol * Update SafeERC20.sol * Update package-lock.json * Revert "deep bignumber comparison removed" This reverts commit 230b272.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per our 'no linter warnings' rule.