Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The beneficiary parameter of claimRefund​ could be confusing #1456

Closed
come-maiz opened this issue Oct 20, 2018 · 0 comments
Closed

The beneficiary parameter of claimRefund​ could be confusing #1456

come-maiz opened this issue Oct 20, 2018 · 0 comments
Labels
bug contracts Smart contract code.

Comments

@come-maiz
Copy link
Contributor

On RefundablCrowdsale:

For ​claimRefund​, beneficiary​ is a loaded word that implies the intended beneficiary from the escrow’s perspective. This is because Escrow​ has a ​ beneficiaryWithdraw​ function and it isn’t the same ​ beneficiary​ that is meant here. Consider calling the parameter ​ refundee​ in the ​ claimRefund function of this contract.

This issue was reported in the LevelK audit.
Aniket-Engg added a commit to Aniket-Engg/zeppelin-solidity that referenced this issue Oct 24, 2018
@Aniket-Engg
fixes OpenZeppelin#1456
b0848c9
@Aniket-Engg Aniket-Engg mentioned this issue Oct 24, 2018
Merged
nventuro pushed a commit that referenced this issue Nov 1, 2018
@Aniket-Engg @nventuro
The beneficiary parameter of claimRefund is replaced with refundee (#…
4f356e3 
…1481)

* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a688977.

* updates

* fixes #1404

* approve failing test

* suggested changes done

* ISafeERC20 removed

* conflict fixes

* fixes #1456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug contracts Smart contract code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@come-maiz