Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC777 : Change visibility of transferFrom, transfer and approve functions from external to public. #1994

Closed
arindamghosh4995 opened this issue Nov 14, 2019 · 1 comment · Fixed by #2001
Closed

ERC777 : Change visibility of transferFrom, transfer and approve functions from external to public. #1994

arindamghosh4995 opened this issue Nov 14, 2019 · 1 comment · Fixed by #2001

Comments

@arindamghosh4995
Copy link
Contributor

arindamghosh4995 commented Nov 14, 2019 •
edited

🧐 Motivation
I am trying to move from a previous implementation of ERC20 to ERC777 with a few custom checks that need to be made before allocating allowances and transfer of tokens.

📝 Details
The current implementation of ERC777 makes moving from ERC20 to ERC777 difficult, since functions like ERC777.transferFrom cannot be called from any child class extending ERC777 contract.
@arindamghosh4995 arindamghosh4995 mentioned this issue Nov 14, 2019
Closed
@frangio
Copy link
Contributor

frangio commented Nov 15, 2019

Would you like to submit a PR?

arindamghosh4995 added a commit to arindamghosh4995/openzeppelin-contracts that referenced this issue Nov 18, 2019
@arindamghosh4995
Changes ERC777 external functions to public for allowing overrides Op…
7dbd040 
…enZeppelin#1994
arindamghosh4995 added a commit to arindamghosh4995/openzeppelin-contracts that referenced this issue Nov 18, 2019
@arindamghosh4995
Changes ERC777 external functions to public for allowing overrides (O…
1af7fa5 
…penZeppelin#1994)
@arindamghosh4995 arindamghosh4995 mentioned this issue Nov 18, 2019
Merged
frangio pushed a commit that referenced this issue Nov 27, 2019
@arindamghosh4995 @frangio
Changes ERC777 external functions to public for allowing overrides #1994
ca6a5dc 
 (#2001)

* Changes ERC777 external functions to public for allowing overrides #1994

* Changes ERC777 external functions to public for allowing overrides (#1994)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@frangio @arindamghosh4995