Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crowdsale docs improvements. #1446

Merged
merged 2 commits into from
Oct 18, 2018
Merged

Conversation

nventuro
Copy link
Contributor

No description provided.

@nventuro nventuro added this to the v2.0 milestone Oct 18, 2018
@nventuro nventuro changed the title Added a small Crowdsale fallback gas warning. Crowdsale docs improvements. Oct 18, 2018
Copy link
Contributor

@come-maiz come-maiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a link to where that 2300 comes from would be good, but that's for somebody else to fix in an hypothetical future :)

@@ -100,15 +103,15 @@ contract Crowdsale {
}

/**
* @return the mount of wei raised.
* @return the amount of wei raised.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@nventuro nventuro merged commit 94692ac into OpenZeppelin:master Oct 18, 2018
@nventuro nventuro deleted the crowdsale-note branch October 18, 2018 19:57
come-maiz pushed a commit that referenced this pull request Oct 21, 2018
* Added a small Crowdsale fallback gas warning.

* Fixed a couple typos.

(cherry picked from commit 94692ac)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants