Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crowdsale docs improvements. #1446

Merged
merged 2 commits into from
Oct 18, 2018
Merged

Crowdsale docs improvements. #1446

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e655bf6
Added a small Crowdsale fallback gas warning.
nventuro Oct 18, 2018
0e06597
Fixed a couple typos.
nventuro Oct 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions contracts/crowdsale/Crowdsale.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ contract Crowdsale {

/**
* @dev fallback function ***DO NOT OVERRIDE***
* Note that other contracts will transfer fund with a base gas stipend
* of 2300, which is not enough to call buyTokens. Consider calling
* buyTokens directly when purchasing tokens from a contract.
*/
function () external payable {
buyTokens(msg.sender);
Expand Down Expand Up @@ -100,15 +103,15 @@ contract Crowdsale {
}

/**
* @return the mount of wei raised.
* @return the amount of wei raised.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

*/
function weiRaised() public view returns (uint256) {
return _weiRaised;
}

/**
* @dev low level token purchase ***DO NOT OVERRIDE***
* @param beneficiary Address performing the token purchase
* @param beneficiary Recipient of the token purchase
*/
function buyTokens(address beneficiary) public payable {

Expand Down Expand Up @@ -186,7 +189,7 @@ contract Crowdsale {
}

/**
* @dev Executed when a purchase has been validated and is ready to be executed. Not necessarily emits/sends tokens.
* @dev Executed when a purchase has been validated and is ready to be executed. Doesn't necessarily emit/send tokens.
* @param beneficiary Address receiving the tokens
* @param tokenAmount Number of tokens to be purchased
*/
Expand Down