Rename permit arguments to match the spec #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriscrutt
added a commit
to chriscrutt/openzeppelin-contracts
that referenced
this pull request
Dec 27, 2020
Update TimelockController.sol (OpenZeppelin#2446) & Rename "amount" to "value" in permit (OpenZeppelin#2445)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP-2612 has the following interface for permit:
function permit(address owner, address spender, uint value, uint deadline, uint8 v, bytes32 r, bytes32 s)Note that third argument is called
valuewhich is also reflected in_PERMIT_TYPEHASH.It is probably better to follow the spec and use the same argument names as in EIP and in the typehash.