Enhancement/heritable encapsulation #692 #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
requested changes
Jan 25, 2018
package.json
Outdated
| @@ -57,6 +57,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "dotenv": "^4.0.0", | |||
| "ethjs-abi": "^0.2.1" | |||
| "ethjs-abi": "^0.2.1", | |||
| "lint": "^1.1.2" | |||
There was a problem hiding this comment.
I think you mistakenly installed this package.
There was a problem hiding this comment.
You are correct. Fixed.
contracts/ownership/Heritable.sol
Outdated
| * @dev Use these getter functions to access the internal variables in | ||
| * an inherited contract. | ||
| */ | ||
| function getHeir() public view returns(address) { |
There was a problem hiding this comment.
As of #666 we've adopted the convention that private state variables with public getters follow the naming convention that
- state variable has a suffix underscore
_, and - getter is the name of the variable without suffix underscore.
In this case, for example, we'd have address private heir_ and function heir() public view.
Can you please change the PR to follow this convention?
frangio
approved these changes
Jan 26, 2018
|
Thanks @trejas! 😄 |
ProphetDaniel
pushed a commit
to classicdelta/Smart-Contracts
that referenced
this pull request
Mar 9, 2018
* Modified Gitignore for Sublime * Added getter functions for public variables * Added encapsulation to Heritable public variables. * Added encapsulation to Heritable public variables. * Added encapsulation to Heritable public variables. * Updated tests to use getter methods instead of, now, private variables. * Conformed variable names to current conventions. * Requested changes * revert package-lock.json changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📘 I've reviewed the OpenZeppelin Contributor Guidelines
✅ I've added tests where applicable to test my new functionality.
DID NOT SEE THE HERITABLE TESTS. fixing now.
📖 I've made sure that my contracts are well-documented.
🎨 I've run the JS/Solidity linters (
npm run lint:all:fix) and fixed any issues.Enhancement #692
🚀 Description
Added encapsulation to Heritable public variables.