New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty unchained function calls #68

Merged

frangio merged 27 commits into master from EmptyUnchained

Jan 24, 2022

Contributor

JulissaDantes commented Jan 14, 2022 •

edited

For the cases where the constructor is empty we dont want the chained function declaration, nor the unchained calls, this PR includes:

Remove unchained function declaration
Remove call from contract chained declaration if it doesnt have parameters
Remove from inheritance call if it doesnt have parameters

JulissaDantes added 6 commits

January 14, 2022 10:46


          Prevent call to unchained function if empty

70e21a6


          Remove extra variable assignment

2051d49


          Remove declaration

f98c500


          Add character on the right initializer

601cea6


          Remove lint warning

a7dd9f4


          Move characters to the right initializer

d259e33

JulissaDantes requested a review from frangio

January 14, 2022 18:08

JulissaDantes changed the title ~~Empty unchained~~ Remove empty unchained function declarations

JulissaDantes marked this pull request as draft

January 14, 2022 18:16


          Include logic in cases where there is not a constructor

c10f53a

frangio reviewed

View reviewed changes

src/transform.test.ts.md Show resolved Hide resolved


          Update local npm version and reinstalled packages

8983a21

JulissaDantes marked this pull request as ready for review

January 17, 2022 12:52

Contributor Author

JulissaDantes commented Jan 17, 2022 •

edited

Update: Must mantain implementation but still remove calls to empty unchained

JulissaDantes changed the title ~~Remove empty unchained function declarations~~ Remove empty unchained function calls

JulissaDantes added 2 commits

January 17, 2022 15:49


          Remove unchained body helper

d1d29d5


          Run lint

9f385e6

JulissaDantes requested a review from frangio

January 17, 2022 19:52

frangio reviewed

View reviewed changes

src/index.test.ts.md Show resolved Hide resolved


          Update modifier check

1fe0bd0

JulissaDantes marked this pull request as draft

January 18, 2022 19:37

Amxx reviewed

View reviewed changes

src/transformations/utils/build-super-calls-for-chain.ts Outdated Show resolved Hide resolved

Amxx reviewed

View reviewed changes

src/transformations/utils/build-super-calls-for-chain.ts Outdated Show resolved Hide resolved

Amxx reviewed

View reviewed changes

src/transformations/utils/build-super-calls-for-chain.ts Outdated Show resolved Hide resolved

Amxx reviewed

View reviewed changes

src/transformations/utils/build-super-calls-for-chain.ts Outdated Show resolved Hide resolved

Amxx reviewed

View reviewed changes

src/transformations/transform-constructor.ts Outdated Show resolved Hide resolved

JulissaDantes added 3 commits

January 19, 2022 08:30


          Remove unused variables on the init method definition

0023ea1


          Update isEmpty

00143fa


          Add explicit types

1e36528

JulissaDantes marked this pull request as ready for review

January 19, 2022 13:13

JulissaDantes requested a review from Amxx

January 19, 2022 13:13

JulissaDantes and others added 8 commits

January 19, 2022 10:21


          Update lock-file

a6cedcd


          Merge branch 'master' into EmptyUnchained

19e727a


          Improve format

58949be


          Update snaps

d52f80c


          Update regex

95cdf90


          Update test snaps

31620b5


          Refactor getUnusedArguments


          Remove logic to check init variablestsc

4268ed9

JulissaDantes requested a review from frangio

January 21, 2022 18:09

frangio added 2 commits

January 21, 2022 18:57


          refactor to reuse code

4f4f73f


          lint

dde1fb6

JulissaDantes mentioned this pull request

Persist constructor modifier #71

Merged

JulissaDantes and others added 3 commits

January 24, 2022 10:53


          Update test snapshots

4807d4c


          Update inheritance type check and add interface inheritance test case

d4acd1e


          invert check

6dfe6ae

frangio approved these changes

View reviewed changes

Contributor

frangio left a comment

Thank you!

frangio merged commit f0c72bb into master

frangio deleted the EmptyUnchained branch

January 24, 2022 18:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment