Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty unchained function calls #68

Merged
merged 27 commits into from Jan 24, 2022
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
70e21a6
Prevent call to unchained function if empty
JulissaDantes Jan 14, 2022
2051d49
Remove extra variable assignment
JulissaDantes Jan 14, 2022
f98c500
Remove declaration
JulissaDantes Jan 14, 2022
601cea6
Add character on the right initializer
JulissaDantes Jan 14, 2022
a7dd9f4
Remove lint warning
JulissaDantes Jan 14, 2022
d259e33
Move characters to the right initializer
JulissaDantes Jan 14, 2022
c10f53a
Include logic in cases where there is not a constructor
JulissaDantes Jan 14, 2022
8983a21
Update local npm version and reinstalled packages
JulissaDantes Jan 17, 2022
d1d29d5
Remove unchained body helper
JulissaDantes Jan 17, 2022
9f385e6
Run lint
JulissaDantes Jan 17, 2022
1fe0bd0
Update modifier check
JulissaDantes Jan 18, 2022
0023ea1
Remove unused variables on the init method definition
JulissaDantes Jan 19, 2022
00143fa
Update isEmpty
JulissaDantes Jan 19, 2022
1e36528
Add explicit types
JulissaDantes Jan 19, 2022
a6cedcd
Update lock-file
JulissaDantes Jan 19, 2022
19e727a
Merge branch 'master' into EmptyUnchained
frangio Jan 19, 2022
58949be
Improve format
JulissaDantes Jan 19, 2022
d52f80c
Update snaps
JulissaDantes Jan 19, 2022
95cdf90
Update regex
JulissaDantes Jan 19, 2022
31620b5
Update test snaps
JulissaDantes Jan 19, 2022
0252790
Refactor getUnusedArguments
JulissaDantes Jan 20, 2022
4268ed9
Remove logic to check init variablestsc
JulissaDantes Jan 21, 2022
4f4f73f
refactor to reuse code
frangio Jan 21, 2022
dde1fb6
lint
frangio Jan 21, 2022
4807d4c
Update test snapshots
JulissaDantes Jan 24, 2022
d4acd1e
Update inheritance type check and add interface inheritance test case
JulissaDantes Jan 24, 2022
6dfe6ae
invert check
frangio Jan 24, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 24 additions & 0 deletions contracts/TransformConstructor.sol
Expand Up @@ -55,3 +55,27 @@ contract Foo7 {
a = _a;
}
}

contract Foo8 {

modifier hasModifier(){
_;
}

constructor() public hasModifier{
}
}

contract Foo9 {
constructor(
uint a,
uint b
) public {
b = 0;
}
}

contract Foo10 is Foo7(123){

uint bar = 1;
}