Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC223 Support #512

Closed
macalinao opened this issue Oct 24, 2017 · 10 comments
Closed

ERC223 Support #512

macalinao opened this issue Oct 24, 2017 · 10 comments
Assignees
Labels
feature New contracts, functions, or helpers. on hold Put on hold for some reason that must be specified in a comment.

Comments

@macalinao
Copy link

macalinao commented Oct 24, 2017

It would be great if a base contract for an ERC223 token was included in this toolkit.

ethereum/EIPs#223

Thoughts? I am interested in implementing this myself.

@macalinao macalinao changed the title ERC-223 Support= ERC223 Support Oct 24, 2017
@GoldenDave
Copy link

Yeah - but we need a standard before it can be implemented.

@maraoz maraoz added the feature New contracts, functions, or helpers. label Nov 11, 2017
iam-dev pushed a commit to iam-dev/openzeppelin-contracts that referenced this issue Dec 14, 2017
@theethernaut
Copy link
Contributor

As far as I can tell, this has already been implemented in ownership/HasNoTokens.sol.

@shrugs
Copy link
Contributor

shrugs commented Jan 4, 2018

@ajsantander ERC223 is more than just the tokenFallback function; and I agree that once the standard figures itself out that we should implement it as we've done with ERC20. Should we re-open this issue?

@frangio frangio reopened this Jan 4, 2018
@theethernaut
Copy link
Contributor

Yes please! My bad, thx @shrugs

@theethernaut theethernaut added next and removed backlog labels Jan 5, 2018
@theethernaut theethernaut self-assigned this Jan 16, 2018
@theethernaut theethernaut added review on hold Put on hold for some reason that must be specified in a comment. and removed next labels Jan 16, 2018
@theethernaut
Copy link
Contributor

This issue is currently addressed by #609, but the PR is put on hold until the standard is defined.

@HarryR
Copy link

HarryR commented Jul 6, 2018

There is another project which supposedly implements the ERC-223 interface: https://github.com/clearmatics/asset-token/blob/master/contracts/AssetToken.sol (although they seem to add other stuff aside from just ERC-223)

Are there any other ERC-223 implementations which we can look at, even if the standard is 'on hold' what matters is that the implementations faithfully do the same thing, I don't think it's fair to wait for ERC-223 to die by feature-creep as extra things are added on when it does something very specific - it allows method chaining of transactions.

@shrugs
Copy link
Contributor

shrugs commented Jul 6, 2018

We now have a process for in-progress proposals! They can be added under the //proposals folder, just like we've done with ERC1047: https://github.com/OpenZeppelin/openzeppelin-solidity/blob/master/contracts/proposals/ERC1046/TokenMetadata.sol

@evseevnn-zzz
Copy link

any news? someone work on this?

@GoldenDave
Copy link

any news? someone work on this?

ERC223 has not really had wide adoption in the community. ERC777 looks like a more likely successor to ERC20

@nventuro
Copy link
Contributor

Closing as stale. Also, 223 is still in the draft stage, and doesn't look like it'll move out of it anytime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New contracts, functions, or helpers. on hold Put on hold for some reason that must be specified in a comment.
Projects
None yet
Development

No branches or pull requests

9 participants