add support for azure resources integration TF resource #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 8, 2024 09:52
rocktavious
reviewed
Jul 8, 2024
rocktavious
reviewed
Jul 8, 2024
rocktavious
reviewed
Jul 8, 2024
rocktavious
reviewed
Jul 8, 2024
rocktavious
reviewed
Jul 8, 2024
rocktavious
reviewed
Jul 8, 2024
| stringplanmodifier.RequiresReplace(), | ||
| }, | ||
| }, | ||
| "last_synced_at": schema.StringAttribute{ |
There was a problem hiding this comment.
this isn't a field on the AWS integration - are we sure it'll be in the public API?
There was a problem hiding this comment.
@rocktavious this will be in the public schema and this is for the Azure Resources integration only.
rocktavious
requested changes
Jul 8, 2024
rocktavious
reviewed
Jul 8, 2024
| @@ -0,0 +1,3 @@ | |||
| kind: Feature | |||
| body: Add support for Azure Resource Integration TF resource | |||
There was a problem hiding this comment.
Suggested change
| body: Add support for Azure Resource Integration TF resource | |
| body: Add support for configuring the OpsLevel Azure Integration |
davidbloss
reviewed
Jul 8, 2024
Co-authored-by: Kyle <kyle@opslevel.com>
Farjaad
reviewed
Jul 29, 2024
| LastSyncedAt types.String `tfsdk:"last_synced_at"` | ||
| Name types.String `tfsdk:"name"` | ||
| SubscriptionId types.String `tfsdk:"subscription_id"` | ||
| TenantId types.String `tfsdk:"tenant_id"` |
There was a problem hiding this comment.
we also added ownershipTagKeys and tagsOverrideOwnership to the mutation and integration type
There was a problem hiding this comment.
Good call out. This has been added in the upstream opslevel-go PR and I have not yet updated here
|
Completed by this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
https://github.com/OpsLevel/team-platform/issues/414
OpsLevel/opslevel-go#430
Changelog
changieentry