-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for azure resources integration TF resource #395
Conversation
stringplanmodifier.RequiresReplace(), | ||
}, | ||
}, | ||
"last_synced_at": schema.StringAttribute{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't a field on the AWS integration - are we sure it'll be in the public API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rocktavious this will be in the public schema and this is for the Azure Resources integration only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments/questions and a few fixes needed
@@ -0,0 +1,3 @@ | |||
kind: Feature | |||
body: Add support for Azure Resource Integration TF resource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
body: Add support for Azure Resource Integration TF resource | |
body: Add support for configuring the OpsLevel Azure Integration |
Co-authored-by: Kyle <kyle@opslevel.com>
LastSyncedAt types.String `tfsdk:"last_synced_at"` | ||
Name types.String `tfsdk:"name"` | ||
SubscriptionId types.String `tfsdk:"subscription_id"` | ||
TenantId types.String `tfsdk:"tenant_id"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also added ownershipTagKeys
and tagsOverrideOwnership
to the mutation and integration type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call out. This has been added in the upstream opslevel-go PR and I have not yet updated here
Completed by this PR |
Issues
https://github.com/OpsLevel/team-platform/issues/414
OpsLevel/opslevel-go#430
Changelog
changie
entry