Db/azure integration #443
Merged
Db/azure integration #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- Co-authored-by: Taimoor <taimoor@opslevel.com>
rocktavious
reviewed
Jul 29, 2024
rocktavious
reviewed
Jul 29, 2024
rocktavious
reviewed
Jul 29, 2024
rocktavious
reviewed
Jul 29, 2024
Comment on lines
+57
to
+58
| "createdAt": "2024-07-04T16:25:29.574450Z", | ||
| "installedAt": "2024-07-04T16:25:28.541124Z", |
There was a problem hiding this comment.
these are here but not in the AzureResourcesIntegrationFragment ?
There was a problem hiding this comment.
createdAt and installedAt are fields in the Integration struct
rocktavious
reviewed
Jul 29, 2024
integration_test.go
Outdated
| "installedAt": "2024-07-04T16:25:28.541124Z", | ||
| "tenantId": "12345678-1234-1234-1234-123456789abc", | ||
| "subscriptionId": "12345678-1234-1234-1234-123456789def", | ||
| "lastSyncedAt": null, |
There was a problem hiding this comment.
this does not appear in the public API
Closed
2 tasks
rocktavious
reviewed
Jul 31, 2024
integration.go
Outdated
| Aliases []string `graphql:"aliases"` | ||
| OwnershipTagKeys []string `graphql:"ownershipTagKeys"` | ||
| SubscriptionId string `graphql:"subscriptionId"` | ||
| TagsOverrideOwnership bool `graphql:"awsTagsOverrideOwnership"` |
There was a problem hiding this comment.
Suggested change
| TagsOverrideOwnership bool `graphql:"awsTagsOverrideOwnership"` | |
| TagsOverrideOwnership bool `graphql:"tagsOverrideOwnership"` |
rocktavious
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
https://github.com/OpsLevel/team-platform/issues/414 - Originally completed by @taimoorgit see PR #430
Changelog
changieentryTophatting