Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(manifests/test): add org.junit.jupiter:junit-jupiter-engine as a …
…test runtime dependency (spinnaker#963) * chore(manifests): remove testImplementation org.junit.vintage:junit-vintage-engine dependency as it's not needed at test compile time, and since build.gradle supplies a test runtime dependency as of spinnaker#958 * fix(manifests/test): add org.junit.jupiter:junit-jupiter-engine as a test runtime dependency so junit5 tests run. Before this PR, 9 tests ran in rosco-manifests, all spock tests. After this PR, 32 tests run. Note that spring-boot-starter-test brings in org.junit.jupiter:junit-jupiter-engine so where that's used, we don't need to declare junit-jupiter-engine explicitly. Note also that rosco-core currently only has spock tests, so although it doesn't use spring-boot-starter-test, it doesn't need org.junit.jupiter:junit-jupiter-engine either.
- Loading branch information