Skip to content

Commit

Permalink
fix(manifests/test): add org.junit.jupiter:junit-jupiter-engine as a …
Browse files Browse the repository at this point in the history
…test runtime dependency (spinnaker#963)

* chore(manifests): remove testImplementation org.junit.vintage:junit-vintage-engine dependency

as it's not needed at test compile time, and since build.gradle supplies a test runtime dependency as of spinnaker#958

* fix(manifests/test): add org.junit.jupiter:junit-jupiter-engine as a test runtime dependency

so junit5 tests run.  Before this PR, 9 tests ran in rosco-manifests, all spock tests.
After this PR, 32 tests run.

Note that spring-boot-starter-test brings in org.junit.jupiter:junit-jupiter-engine so
where that's used, we don't need to declare junit-jupiter-engine explicitly.  Note also
that rosco-core currently only has spock tests, so although it doesn't use
spring-boot-starter-test, it doesn't need org.junit.jupiter:junit-jupiter-engine either.
  • Loading branch information
dbyron-sf authored and yugaa22 committed Jun 26, 2023
1 parent b0ebb10 commit 7bca94e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rosco-manifests/rosco-manifests.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ dependencies {
testImplementation "org.junit.jupiter:junit-jupiter-api"
testImplementation "org.junit.jupiter:junit-jupiter-params"
testImplementation "org.junit.platform:junit-platform-runner"
testImplementation "org.junit.vintage:junit-vintage-engine"
testImplementation "org.mockito:mockito-core"
//testImplementation "org.spockframework:spock-core"
//api(platform("org.spockframework:spock-bom:2.4-M1-groovy-4.0"))
testImplementation "org.spockframework:spock-core"
implementation("jakarta.annotation:jakarta.annotation-api:2.1.1")
testImplementation("jakarta.annotation:jakarta.annotation-api:2.1.1")

testRuntimeOnly "org.junit.jupiter:junit-jupiter-engine"
}

0 comments on commit 7bca94e

Please sign in to comment.