fix(manifests/test): add org.junit.jupiter:junit-jupiter-engine as a test runtime dependency #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…intage-engine dependency as it's not needed at test compile time, and since build.gradle supplies a test runtime dependency as of spinnaker#958
…test runtime dependency so junit5 tests run. Before this PR, 9 tests ran in rosco-manifests, all spock tests. After this PR, 32 tests run. Note that spring-boot-starter-test brings in org.junit.jupiter:junit-jupiter-engine so where that's used, we don't need to declare junit-jupiter-engine explicitly. Note also that rosco-core currently only has spock tests, so although it doesn't use spring-boot-starter-test, it doesn't need org.junit.jupiter:junit-jupiter-engine either.
jasonmcintosh
approved these changes
Mar 21, 2023
yugaa22
pushed a commit
to OpsMx/rosco-oes
that referenced
this pull request
Jun 26, 2023
…test runtime dependency (spinnaker#963) * chore(manifests): remove testImplementation org.junit.vintage:junit-vintage-engine dependency as it's not needed at test compile time, and since build.gradle supplies a test runtime dependency as of spinnaker#958 * fix(manifests/test): add org.junit.jupiter:junit-jupiter-engine as a test runtime dependency so junit5 tests run. Before this PR, 9 tests ran in rosco-manifests, all spock tests. After this PR, 32 tests run. Note that spring-boot-starter-test brings in org.junit.jupiter:junit-jupiter-engine so where that's used, we don't need to declare junit-jupiter-engine explicitly. Note also that rosco-core currently only has spock tests, so although it doesn't use spring-boot-starter-test, it doesn't need org.junit.jupiter:junit-jupiter-engine either.
nemesisOsorio
pushed a commit
to OpsMx/rosco-oes
that referenced
this pull request
Apr 27, 2024
…test runtime dependency (spinnaker#963) * chore(manifests): remove testImplementation org.junit.vintage:junit-vintage-engine dependency as it's not needed at test compile time, and since build.gradle supplies a test runtime dependency as of spinnaker#958 * fix(manifests/test): add org.junit.jupiter:junit-jupiter-engine as a test runtime dependency so junit5 tests run. Before this PR, 9 tests ran in rosco-manifests, all spock tests. After this PR, 32 tests run. Note that spring-boot-starter-test brings in org.junit.jupiter:junit-jupiter-engine so where that's used, we don't need to declare junit-jupiter-engine explicitly. Note also that rosco-core currently only has spock tests, so although it doesn't use spring-boot-starter-test, it doesn't need org.junit.jupiter:junit-jupiter-engine either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so junit5 tests run. Before this PR, 9 tests ran in rosco-manifests, all spock tests. After this PR, 32 tests run.
Before:
After:
Note that spring-boot-starter-test brings in org.junit.jupiter:junit-jupiter-engine so where that's used, we don't need to declare junit-jupiter-engine explicitly. Note also that rosco-core currently only has spock tests, so although it doesn't use spring-boot-starter-test, it doesn't need org.junit.jupiter:junit-jupiter-engine either.