Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hooks on generateHistoricalMetrics #380

Closed
Symbolic76 opened this issue Apr 21, 2022 · 1 comment · Fixed by #400
Closed

Add hooks on generateHistoricalMetrics #380

Symbolic76 opened this issue Apr 21, 2022 · 1 comment · Fixed by #400
Labels
feature request 💡 New ideas next release 🚀 Will be included in the next release of the library

Comments

@Symbolic76
Copy link

I've been trying to mock API calls to be able to cancel requests from generateHistoricalMetrics.

I realized there is no hooks on this method and i can't mock this properly.

@wcoots
Copy link
Contributor

wcoots commented Apr 28, 2022

@Symbolic76 Interesting idea, this would involve creating a generic hook for all service methods with the method called being passed as an argument (or perhaps just the name of the function). We will consider this for the next version of the API.

@wcoots wcoots added the feature request 💡 New ideas label Apr 28, 2022
@wcoots wcoots added the next release 🚀 Will be included in the next release of the library label Jun 21, 2022
@wcoots wcoots linked a pull request Jun 21, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request 💡 New ideas next release 🚀 Will be included in the next release of the library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants