Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A6000 support for FlashAttentionV2 #665

Closed
zhangliang-04 opened this issue Oct 24, 2023 · 3 comments
Closed

A6000 support for FlashAttentionV2 #665

zhangliang-04 opened this issue Oct 24, 2023 · 3 comments

Comments

@zhangliang-04
Copy link

Is your feature request related to a problem? Please describe.
It seems that this codebase only supports the use of FlashAttentionV2 on A100 or A40. However, in theory all Turing or Ampere GPUs should work with it. Is there any plan for supporting A6000?

Describe the solution you'd like
Add FlashAttention support for A6000 gpu.
@research4pan
Copy link
Contributor

Thanks for pointing that out! Yeah I think it is totally possible, and all the required change is this line in install.sh (https://github.com/OptimalScale/LMFlow/blob/main/install.sh#L6). I will modify it soon when I have some time. Also, if you are interested in contributing, we welcome all kinds of contributions via PR. Thanks 😄

@research4pan
Copy link
Contributor

We have updated install.sh accordingly (#669). Could you please let us know if the problem is solved? Thanks 😄

@zhangliang-04
Copy link
Author

Yes, it works! Thanks for your contribution😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhangliang-04 @research4pan