Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After installing v0.5.0, the "dce version" still shows up as v0.4.0 #86

Open
gundkalneha opened this issue May 8, 2020 · 2 comments
Open

Comments

@gundkalneha
Copy link

Version

  • DCE CLI v0.4.0
  • Darwin C02XC78CJGH5 17.7.0 Darwin Kernel Version 17.7.0: Sun Jun 2 20:31:42 PDT 2019; root:xnu-4570.71.46~1/RELEASE_X86_64 x86_64
  • go version go1.14.2 darwin/amd64
  • Terraform v0.12.20

Describe the bug
Trying to upgrade v0.4.0 to v0.5.0.
When installing DCE CLI with version 0.5.0, the dce version in terminal still appears as 0.4.0.

To Reproduce

Steps to reproduce the behavior:

  1. When I type this Command, I get the following output

Download the zip file

wget https://github.com/Optum/dce-cli/releases/download/**v0.5.0**/dce_darwin_amd64.zip

Unzip to a directory on your path

unzip dce_darwin_amd64.zip -d /usr/local/bin
~ dce version **0.4.0**

Expected behavior
Version should be 0.5.0 but shows 0.4.0

@nelsonjchen
Copy link

I think this occurred because "0.5.0" was built on somebody's developer machine before the 0.5.0 tag was created or their local repository was missing the tag:

VERSION := $(shell git describe --always --long --dirty)

@nelsonjchen
Copy link

My suggestion for this fix would be to make sure the builds that get uploaded to GitHub or whatever come from a CI/CD server that builds when a tag is pushed. Discipline that and this is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants