Bugfix/boolean triggers #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue with ruamel_yaml imports
# Conflicts: # gramhopper/configuration/boolean_helper.py # gramhopper/configuration/rules_parsing_helper.py
meirhalachmi
reviewed
Mar 6, 2019
| @@ -22,7 +22,9 @@ def parse_single(cls, config, global_elements): # pylint: disable=unused-argume | |||
| mapping_cls = cls.mapping_class() | |||
| element_cls = mapping_cls[config_copy.pop('type')] | |||
|
|
|||
| return element_cls(**config_copy) | |||
| if isclass(element_cls): | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Some triggers are classes (most of them actually), but some are instances (mostly filter triggers). This allows both cases to be used.
There was a problem hiding this comment.
Hmm.. Then the name "element_cls" isn't so good.
Additionally, why do we have this ambiguity?
There was a problem hiding this comment.
- You are right. I'll rename.
- Filter triggers are mostly instances of
FilterBasedTriggerreceivingBaseFilter. I could have created some lambda to make it feel like a class constructor, but it would make filter_trigger.py look like shit.
meirhalachmi
approved these changes
Mar 8, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.