Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor filter triggers #39

Closed
OrBin opened this issue Mar 13, 2019 · 1 comment
Closed

Refactor filter triggers #39

OrBin opened this issue Mar 13, 2019 · 1 comment
Assignees
@meirhalachmi
Labels
refactor
Milestone
C

Comments

@OrBin
Copy link
Owner

OrBin commented Mar 13, 2019

As explained here, some of the filter triggers are instances, not classes.
Try to make them all the same, preferably make them all classes.
@OrBin OrBin added the refactor label Mar 13, 2019
@OrBin OrBin added this to the C milestone Mar 13, 2019
@OrBin OrBin mentioned this issue Mar 13, 2019
Closed
@meirhalachmi meirhalachmi self-assigned this Mar 24, 2019
meirhalachmi added a commit that referenced this issue May 2, 2019
@meirhalachmi
#39 Merged all the existing instance-only filters under a new FilterB…
468cb70 
…asedTrigger based class, called _MessageTypeFilterBasedTrigger
meirhalachmi added a commit that referenced this issue May 2, 2019
@meirhalachmi
#39 Added support for nested filters (for example, status_update.some…
96aaa11 
…thing)
meirhalachmi added a commit that referenced this issue May 3, 2019
@meirhalachmi
#39 Fixed lint rejects
054272e
meirhalachmi added a commit that referenced this issue May 3, 2019
@meirhalachmi
#39 PR minor changes
83b7b0d
OrBin added a commit that referenced this issue May 3, 2019
@OrBin
#39 Refactor Filter Triggers (#61)
66a979c 
#39 Refactor Filter Triggers
Closing #39
@OrBin
Copy link
Owner Author

OrBin commented May 3, 2019

Closed in #61.

@OrBin OrBin closed this as completed May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meirhalachmi meirhalachmi

Labels
refactor
Projects
None yet
Milestone
C
Development

No branches or pull requests
2 participants
@OrBin @meirhalachmi