Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ipad width breaks one aspect. #3

Closed
ryleyherrington opened this issue Nov 7, 2016 · 2 comments
Closed

Ipad width breaks one aspect. #3

ryleyherrington opened this issue Nov 7, 2016 · 2 comments
Milestone

Comments

@ryleyherrington
Copy link

ryleyherrington commented Nov 7, 2016

Hey, just tried using it in my app and made a small change to:
https://github.com/OrRon/ConfettiView/blob/master/ConfettiView/Classes/ConfettiLayer.swift#L128

Instead of 380 I used self.view.frame.size.width and then it works on iPad as well as iphones and doesn't necessarily use 380 on older devices which are only 320. I'd make a new branch and ask for a PR but honestly this is a very small change and you might not want to do it. But it was just a suggestion!

@OrRon
Copy link
Owner

OrRon commented Nov 12, 2016

Thank you @ryleyherrington 🚀 ,

It's small but noticeable and important.
I will be fixing it in the beginning of the week.

Cheers,
Or.

@OrRon OrRon added this to the 0.1.7 milestone Nov 12, 2016
@OrRon
Copy link
Owner

OrRon commented Nov 14, 2016

abc3079

@OrRon OrRon closed this as completed Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants