Improvements to Animation Tags #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored CreateNewImage dialog and added portrait & landscape butto…
update master
New Crowdin updates (#400)
It was originally made to use primarily in "Spritesheet (new layer)" but it thought it could also be useful to put it there as an import option
Added more standart devices from 8/16Bit era (#450)
"SpriteSheet as layer" and "Replace Frame" import options (#453)
* Add keyboard shortcut for Clear Selection (#457) * Fix issue where the window regains focus and draws immediatly The issue occurred when the cursor exited the application window very fast while still on the canvas, thus Global.has_focus was still true, then lost focus. When Pixelorama regained focus, it would draw the tool even if the user clicked outside of the drawing canvas. * full support for auto tallscreen/widescreen panel layout (#458) * full support for auto tallscreen/widescreen panel layout * Update Main.tscn * Update CanvasPreviewContainer.tscn * Update UI.tscn * tallscreen support - better display scale * tallscreen support - better display scale * Update UI.tscn * Update Main.gd * tallscreen support - better display scale * tallscreen support - better display scale * tallscreen support - alternate panel placement comment-784228607 * tallscreen support - code cleanup * tallscreen support - color picker swap: comment-785032683 * prettier border * tallscreen support - color picker * tallscreen support - pullrequestreview-601156079 * tallscreen support - bugfix & review Co-authored-by: ballerburg9005 <mathias.steiger@gmail.com> * Update CHANGELOG & Translations, clear whitespaces * Update CHANGELOG * Made the splash screen fully opaque again * Added an option in the Preferences for interface dimming on dialog popup * New Crowdin updates (#451) * New translations Translations.pot (Polish) * New translations Translations.pot (German) * New translations Translations.pot (Korean) * New translations Translations.pot (Korean) * New translations Translations.pot (Korean) * New translations Translations.pot (Ukrainian) * New translations Translations.pot (Ukrainian) * New translations Translations.pot (Ukrainian) * New translations Translations.pot (Spanish) * New translations Translations.pot (Romanian) * New translations Translations.pot (French) * New translations Translations.pot (Polish) * New translations Translations.pot (French) * New translations Translations.pot (Russian) * New translations Translations.pot (Hungarian) * New translations Translations.pot (Russian) * New translations Translations.pot (Hungarian) * New translations Translations.pot (Korean) * New translations Translations.pot (Romanian) * New translations Translations.pot (French) * New translations Translations.pot (Spanish) * New translations Translations.pot (Afrikaans) * New translations Translations.pot (Arabic) * New translations Translations.pot (Catalan) * New translations Translations.pot (Czech) * New translations Translations.pot (Danish) * New translations Translations.pot (German) * New translations Translations.pot (Greek) * New translations Translations.pot (Finnish) * New translations Translations.pot (Hebrew) * New translations Translations.pot (Italian) * New translations Translations.pot (Japanese) * New translations Translations.pot (Dutch) * New translations Translations.pot (Esperanto) * New translations Translations.pot (Norwegian) * New translations Translations.pot (Polish) * New translations Translations.pot (Portuguese) * New translations Translations.pot (Serbian (Cyrillic)) * New translations Translations.pot (Swedish) * New translations Translations.pot (Turkish) * New translations Translations.pot (Ukrainian) * New translations Translations.pot (Chinese Simplified) * New translations Translations.pot (Chinese Traditional) * New translations Translations.pot (Vietnamese) * New translations Translations.pot (Portuguese, Brazilian) * New translations Translations.pot (Indonesian) * New translations Translations.pot (Latvian) * New translations Translations.pot (Hindi) * New translations Translations.pot (Greek) * New translations Translations.pot (Japanese) * New translations Translations.pot (Korean) * New translations Translations.pot (Korean) * New translations Translations.pot (Chinese Simplified) * New translations Translations.pot (Romanian) * New translations Translations.pot (Italian) * New translations Translations.pot (German) * New translations Translations.pot (Russian) * New translations Translations.pot (Dutch) * New translations Translations.pot (Hindi) * New translations Translations.pot (Latvian) * New translations Translations.pot (Indonesian) * New translations Translations.pot (Portuguese, Brazilian) * New translations Translations.pot (Vietnamese) * New translations Translations.pot (Chinese Traditional) * New translations Translations.pot (Chinese Simplified) * New translations Translations.pot (Ukrainian) * New translations Translations.pot (Turkish) * New translations Translations.pot (Swedish) * New translations Translations.pot (Serbian (Cyrillic)) * New translations Translations.pot (Portuguese) * New translations Translations.pot (Polish) * New translations Translations.pot (Norwegian) * New translations Translations.pot (Korean) * New translations Translations.pot (Hungarian) * New translations Translations.pot (Japanese) * New translations Translations.pot (Italian) * New translations Translations.pot (Hebrew) * New translations Translations.pot (Finnish) * New translations Translations.pot (Greek) * New translations Translations.pot (German) * New translations Translations.pot (Danish) * New translations Translations.pot (Czech) * New translations Translations.pot (Catalan) * New translations Translations.pot (Arabic) * New translations Translations.pot (Afrikaans) * New translations Translations.pot (Spanish) * New translations Translations.pot (French) * New translations Translations.pot (Romanian) * New translations Translations.pot (Esperanto) * New translations Translations.pot (Greek) * New translations Translations.pot (German) * New translations Translations.pot (Italian) * New translations Translations.pot (Polish) * New translations Translations.pot (Hungarian) * New translations Translations.pot (Hungarian) * New translations Translations.pot (Hungarian) * New translations Translations.pot (Hungarian) * New translations Translations.pot (Korean) * New translations Translations.pot (Korean) * Update Translations.pot * Apply mirror view to all tools * Add Rectangle and Ellipse tools (#456) * Add Shapes Tool (WIP) * Add Alt button + Fill shape + Other stuff * Add blue theme button textures * Fix tool not previewing on right button * Add config functions * Fix ellipse bug * Correctly added thickness * Keep preview with CTRL * Fix weird PoolVector behaviour * Make preview follow mouse when pressing CTRL * Moved shapes class to a separate script * Update tooltip * Enable mirrors * Separate tools + jittery preview fix + more * Add missing translation * Add missing icons and keybindings * Changed shape draw function buttons Co-authored-by: DragonOfWar <47753585+KawanWeege@users.noreply.github.com> * Do not run update_mask() method if there is no pressure sensitivity option Major speedup for large images. update_mask() is meant for pen pressure only, so there is no reason to calculate it if we don't have pressure sensitivity enabled * Fix hue and saturation getting reset when draging value slider to zero (#473) * Replace old palette system with a new one (#447) * Replace old palette system with a new one * Replace default json palettes with new resource versions * Add missing translation strings * Fix Erevoid's issues 2, 3 and 4 * Rewrite palette grid to improve performance Add middle click scrolling * Fix index conversion functions * Fix palettes editing by copying them to XDG user write path * Add Windows specific fixes * Add import support for old json palette format * Add create/edit palette settings check. Hide add/delete color buttons when no palette is displayed. * Remove paths from Main.tscn from the palette PR * Restored LightenDarken's previous behavior Fixes a minor issue from 6cce27a * Update CHANGELOG & AboutDialog * New selection system (#474) * Basic move tool * Added marching ants effect on the selection borders * Rename SelectionRectangle to SelectionShape, make it have non-rectangular shape and multiple SelectionShapes can exist - Create multiple selection rectangles - Merge them together if they intersect - Move the selections (without contents as of right now) - Gizmos are being drawn but they are not functional yet Code is very ugly. * Sort vectors counter-clockwise to be used as polygon borders I did this, no idea if it works properly, probably won't be used but I thought I'd keep it saved somewhere * More experiments I may or may not need Trying to generate a polygon from the individual selected pixels * Change default rectangle select behavior and ability to clip polygons using Control * Fix rectangle selection clipping * Split polygon into two with selection subtracting * Move selection with contents with the move tool Code is still a mess, don't bother looking. * Move some methods from SelectionShape.gd to Selection.gd The purpose of this is to generalize some selection code, so that it applies to all polygons, the entire selection. More will follow. * UndoRedo for border moving Nothing else in the selections system works properly in UndoRedo right now. Needs: - UR support for creating selections - UR support for modifying selections (merging and cutting selections together) - UR support for removing selection - UR support for moving content & for all the rest of the remaining features * Moving all of the selection shape logic to Selection.gd Handle all of the polygons there instead of having them as individual nodes. Should be easier to handle undo/redo this way. This commit probably breaks move tool + selection tool and undo/redo. Code is still a mess. For your sanity, I hope you are not reading this. I promise I will clean up. * Move tool works again Buggy and messy, of course. * Remove unneeded code and restore selection move undoredo logic * Made Selection.gd have one big preview_image for when moving content, instead of each polygon having its own image Could be further optimized for some specific cases. We could also remove selected_pixels from SelectionPolygon. * UndoRedo support for creating, deleting, merging and clipping selections UndoRedo support for moving content not added in this commit. Should work but needs more testing. This PR also removes selected_pixels from the SelectionPolygon class. * Confirm & cancel selection movement, should support undoredo properly too Press Enter or do any editing to confirm movement, Escape to cancel. I will most likely add UI buttons for confirm and cancel too. * Mirror View affects selection * Restore Cut, Copy, Paste and Clear Selection Pasting now no longer requires a pre-existing selection and instead copies the selections themselves too. * Created a new Select menu, which has Select All and Clear Selection as options Clear Selection now also confirms content moving. TopMenuContainer code has changed to no longer rely on Global for the menu buttons. * Draw gizmos as rectangles No functionality yet. They may need to be turned to nodes, so that they can easily resize based on zoom level and check for mouse enter/exit events. * Made gizmos get drawn in the sides and corners of the big bounding rectangle instead of individual selection parts Still no functionality yet. * Restore label text * Minor optimization when clipping selections This will execute the for loop less times * Made a Gizmo class, cursor change on hover, has_focus = false on mouse click Now I should actually make them resize when dragged, aye? * Very basic gizmo resizing, still a WIP, does not work properly yet * Start replacing the array of selected pixels with a BitMap This should optimize the selection making a lot, and it also allows for easy border drawing without having to deal with polygons, thanks to the MarchingAntsOutline.shader Still commit is still a WIP, image effects and brushes may not work properly yet. Because the BitMap has a fixed size, the size of the project, moving the selection outside of canvas boundaries has proven to be a bit tricky. I did implement a hacky way of handling it, but it may be buggy and problematic. I'm still unsure whether this is the best way to handle the situation. * Selection works with mirror view * Draw a black rectangle when the user is making a rectangular selection After they release the mouse, the black rectangle becomes the selection * Make Selection.gd update when undoing/redoing * Fix brushes not working properly with non-rectangular selections * Added invert selection * Cache has_selection as a variable for a speedup * Fix conflict issues with the shape tools * Made the bitmap image squared so the marching ants effect will be the same on both dimensions There may be a better way to fix the issue, perhaps inside the shader itself. * Some optimizations to call selection_bitmap_changed() less times * Restored almost all of the image effects Left to do: - Change gradient's behavior. Unsure of how it will work with non-rectangular selections yet, but it should not generate pixels outside of the selection. - Restore rotation - Resize bitmap on image resize - Remove the `pixels` array from the ImageEffect * Fix Selection.gd not updating when changing project * Resize the selection bitmap along with image resize * Restored rotation's old behavior and finally got rid of the selected_pixels array The rotation does not yet work properly with selections, but at least it now "works". * Resize selection too when using gizmos Left to do for gizmos: - Proper cancel transformation - Begin transformation (currently named move_content_start but it should be renamed to something more general) when resizing gizmos - Keep the original image and selection in memory and resize them. Meaning, gizmos should not resize the already resized data, but only resize the original. This is less destructive as there is no danger of data loss. - Always resize on InputEventMouseMotion. This is going to be worse for performance, but it will look better for the user. * Image and bitmap resizing now uses the original data and begin transformation on gizmo click No matter how many times the user resizes on the current transformation, the original data will not be lost until they either confirm or cancel, so there is no data loss before confirmation/cancel. * Cancel transformation now works properly when the selection has been resized * Made gizmos resize on mouse motion, fix issues with negative bounding rectangle and when combined with the move tool * Resizing can now get out of positive bounds, clearing and inverting now gets limited to the canvas bounds Resizing currently does not work properly with negative (left & up) canvas boundaries * Flip image when resizing and the bounding rectangle gets flipped * Call move_content_confirm() when inverting selection * Attempt to implement selection resizing that goes outside of the canvas boundaries (not working properly yet) * Flip selection when resizing to negative bounding rectangle sizes And fix preview_image vertical flipping * Fix rotation so that it works (almost) properly with selections Rotation algorithms now accept and only work with a given image, and the pivot has been added as a parameter * Experimental gizmo rotation - does not work properly yet Transforming the selection outside of the canvas is still broken. * Fix some issues with moving selection out of canvas bounds * Fix more issues with selection getting resized outside of canvas bounds * Update marching ants effect properly when switching between projects And make sure the frequency of the marching ants effect always looks roughly the same on all project sizes * Made the rotation gizmo part of the gizmos array and resize them based on camera zoom * Remove unneeded parameter from move_bitmap_values() * Remove more unneeded parameters * Move the selection only if the cursor is above it and neither shift nor control are currently pressed * Gradient generation now works on non-rectangular selections Although this behavior might not be the intended one * Copy/paste marching ants effect offset Useful for when the selection is in negative coords * Fix issue with clear selection & UndoRedo * Restore the ability to move selection when it's in negative coords * Made the marching ants offset a Project variable This fixes the issue of project switching and keeping the previous project's offset. Again, this is only relevant for when the selection is in negative coords. * Made the "from current selection" palette preset work with the new selection system * Fix out of bounds error when using the rectangular select tool on negative coords * Some code cleanup * Comment out the rotation gizmo for now, since it does not work properly * Update marching ants shader params and gizmo sizes when the bitmap changes * Move some methods around in Selection.gd * Fix HTML5 shader issue The MarchingAntsOutline was failing to compile on the Web platform due to the for loop not having constant expressions inside the shader. "Loop index cannot be initialized with non-constant expression" * Optimize Project.get_selection_rectangle It doesn't call bitmap_to_image() anymore. * Change the way of how tool icon blue-orange backgrounds work Instead of having a gazillion icons for each tool and its blue-orange variations, which led us to create 4 different textures for each tool, now we only need one texture for each tool and each theme. The blue-orange background has been made into a different TextureRect for each button. This makes it easier for people to create new tools. Now, each new tool requires 3 textures (to cover every theme), instead of 12(!). I'm hoping to bring the number down to 1 in a future commit, by automating the theme color converting process. * Pasting does not directly paste on the canvas, it is now confirmable instead This lets the user easily cancel the pasting and move just the pasted area around. * New tool: Select by Color (temporary icon) When the user clicks on a pixel, all pixels of the same color are being selected. Shift adds to the selection, Ctrl subtracts. The icon and the hint tooltip are temporary. * Fix Copy & Delete to work on the currently selected parts of the image This also fixed a crash when deleting while content is being moved/resized * Call move_content_confirm() when layers and frames change * New tool: Magic Wand (temporary icon) * Make layers uneditable when they're invisible * Image effects will not longer get applied to locked and/or hidden layers. * Fixed bug when copying while moving content * Shader based invert, desaturate and HSV dialogs (#475) * Shader based invert, desaturate and HSV dialogs * Bug fixes * Fix gizmos being able to get edited when there is no selection * Gizmos resizing no longer re-flips the image when temp_rect is negative * Fix selection_offset not being reset to 0 when the bitmap's position is back to positive coordinates * Got rid of the deprecated enabled_focus_mode Godot 3.3 has arrived! * Change the order of the top menus * Fix issue when resizing selection after moving it * Add 1:1 rectangle tool creation and expanding from click position as its center Works similar to the rectangle & ellipse drawing tools. Shift for 1:1, Ctrl for expanding from center. Shift + mouse click = add to selection Ctrl + mouse click = subtract from selection Mouse click + Shift = Create a 1:1 (square) selection Mouse click + Ctrl = Create a selection that expands from center Mouse click + Shift + Ctrl = Create a 1:1 (square) selection that expands from center A combination like Shift + Mouse Click + Shift will add to selection while also making a 1:1 selection * Add selection intersection with Ctrl + Shift + Mouse click * Update the tool icons * Bump version to v0.9-dev and use Godot 3.3 in GitHub Actions * Fix selection being moved by one pixel when being resized & temp_rect has negative size * Rename move_content methods to transform_content * Add enter and escape as input actions * Restore project brush creation when copying * [CI] Bump Godot's version to 3.3 for macOS binaries * [CI - macOS] Remove the -size parameter from the hdiutil command * Update CHANGELOG & export_presets * New Crowdin updates (#468) * New translations Translations.pot (Hebrew) * New translations installer.pot (Hebrew) * New translations Translations.pot (Hebrew) * New translations installer.pot (Hebrew) * New translations Translations.pot (Vietnamese) * New translations Translations.pot (Russian) * New translations Translations.pot (Hungarian) * New translations Translations.pot (Korean) * New translations Translations.pot (Romanian) * New translations Translations.pot (French) * New translations Translations.pot (Spanish) * New translations Translations.pot (Afrikaans) * New translations Translations.pot (Arabic) * New translations Translations.pot (Catalan) * New translations Translations.pot (Czech) * New translations Translations.pot (Danish) * New translations Translations.pot (German) * New translations Translations.pot (Greek) * New translations Translations.pot (Finnish) * New translations Translations.pot (Hebrew) * New translations Translations.pot (Italian) * New translations Translations.pot (Japanese) * New translations Translations.pot (Dutch) * New translations Translations.pot (Esperanto) * New translations Translations.pot (Norwegian) * New translations Translations.pot (Polish) * New translations Translations.pot (Portuguese) * New translations Translations.pot (Serbian (Cyrillic)) * New translations Translations.pot (Swedish) * New translations Translations.pot (Turkish) * New translations Translations.pot (Ukrainian) * New translations Translations.pot (Chinese Simplified) * New translations Translations.pot (Chinese Traditional) * New translations Translations.pot (Vietnamese) * New translations Translations.pot (Portuguese, Brazilian) * New translations Translations.pot (Indonesian) * New translations Translations.pot (Latvian) * New translations Translations.pot (Hindi) * New translations Translations.pot (Greek) * New translations Translations.pot (Romanian) * New translations Translations.pot (Italian) * New translations Translations.pot (Japanese) * New translations Translations.pot (German) * New translations Translations.pot (Japanese) * New translations Translations.pot (Korean) * New translations Translations.pot (Russian) * New translations Translations.pot (Dutch) * New translations Translations.pot (Hindi) * New translations Translations.pot (Latvian) * New translations Translations.pot (Indonesian) * New translations Translations.pot (Portuguese, Brazilian) * New translations Translations.pot (Vietnamese) * New translations Translations.pot (Chinese Traditional) * New translations Translations.pot (Chinese Simplified) * New translations Translations.pot (Ukrainian) * New translations Translations.pot (Turkish) * New translations Translations.pot (Swedish) * New translations Translations.pot (Serbian (Cyrillic)) * New translations Translations.pot (Portuguese) * New translations Translations.pot (Polish) * New translations Translations.pot (Norwegian) * New translations Translations.pot (Korean) * New translations Translations.pot (Hungarian) * New translations Translations.pot (Japanese) * New translations Translations.pot (Italian) * New translations Translations.pot (Hebrew) * New translations Translations.pot (Finnish) * New translations Translations.pot (Greek) * New translations Translations.pot (German) * New translations Translations.pot (Danish) * New translations Translations.pot (Czech) * New translations Translations.pot (Catalan) * New translations Translations.pot (Arabic) * New translations Translations.pot (Afrikaans) * New translations Translations.pot (Spanish) * New translations Translations.pot (French) * New translations Translations.pot (Romanian) * New translations Translations.pot (Esperanto) * New translations Translations.pot (German) * New translations Translations.pot (Romanian) * New translations Translations.pot (Romanian) * New translations Translations.pot (Italian) * New translations Translations.pot (Italian) * New translations Translations.pot (Chinese Simplified) * New translations Translations.pot (Chinese Simplified) * New translations Translations.pot (Chinese Simplified) * New translations Translations.pot (Korean) * New translations Translations.pot (Korean) * New translations Translations.pot (Japanese) * New translations Translations.pot (Hindi) * New translations Translations.pot (Hindi) * New translations Translations.pot (Russian) * New translations Translations.pot (Polish) * New translations Translations.pot (Polish) * New translations Translations.pot (Russian) * New translations Translations.pot (Japanese) * New translations Translations.pot (Latvian) * New translations Translations.pot (Indonesian) * New translations Translations.pot (Portuguese, Brazilian) * New translations Translations.pot (Vietnamese) * New translations Translations.pot (Chinese Traditional) * New translations Translations.pot (Chinese Simplified) * New translations Translations.pot (Ukrainian) * New translations Translations.pot (Turkish) * New translations Translations.pot (Swedish) * New translations Translations.pot (Serbian (Cyrillic)) * New translations Translations.pot (Portuguese) * New translations Translations.pot (Norwegian) * New translations Translations.pot (Dutch) * New translations Translations.pot (Korean) * New translations Translations.pot (Italian) * New translations Translations.pot (Polish) * New translations Translations.pot (Hungarian) * New translations Translations.pot (Hebrew) * New translations Translations.pot (Finnish) * New translations Translations.pot (Greek) * New translations Translations.pot (German) * New translations Translations.pot (Danish) * New translations Translations.pot (Czech) * New translations Translations.pot (Catalan) * New translations Translations.pot (Arabic) * New translations Translations.pot (Afrikaans) * New translations Translations.pot (Spanish) * New translations Translations.pot (French) * New translations Translations.pot (Romanian) * New translations Translations.pot (Hindi) * New translations Translations.pot (Esperanto) * New translations Translations.pot (Romanian) * New translations Translations.pot (Romanian) * New translations Translations.pot (Italian) * New translations Translations.pot (Russian) * New translations Translations.pot (Chinese Simplified) * New translations Translations.pot (Chinese Simplified) * New translations Translations.pot (Japanese) * New translations Translations.pot (Korean) * New translations Translations.pot (Korean) * New translations Translations.pot (Polish) * New translations Translations.pot (Korean) * New translations Translations.pot (Greek) * Create a parent SelectTool script where all selection tools extend from * Organize the selection tool files in a new folder * Make selection tool scenes inherit from SelectionTool.tscn Useful for them to be able to share common tool options * Update dev-desktop-builds.yml (#476) * Update dev-desktop-builds.yml Changed download location for Godot headless binary * Update dev-desktop-builds.yml * Update dev-desktop-builds.yml Replaced curl with wget on headless binary download * Removed wget installation command * Update release.yml * Add position and size as selection tool options This allows the user to easily move and resize selections * Move selection with contents by default with all selection tools Now, if you want to move the selection itself without its contents, you have to do Ctrl + Alt + Mouse click. Works the same with all selection tools. * Fix issue with gizmos not working if the user has moved the selection with contents first * Fix out of bounds errors with selection intersection * Added a displace origin option to Rectangle, Ellipse and Rectangle Selection tools Works with Mouse Click + Alt. Needs to be documented in the tooltips. * Snap movement to axis by holding Shift after mouse clicking Works with the Move tool and with the Selection tools. * Implement Alt + mouse movement to quickly copy & move selection contents without cutting them from their original position * Implement snap to grid while moving selections and using the Move tool Mouse click + Ctrl to snap to grid while moving. * Minor UI changes in the tool options of shape tools * Prepare for v0.8.3-stable * Update AboutDialog.gd Co-authored-by: gamesplease <61508621+Gamespleasure@users.noreply.github.com> Co-authored-by: Manolis Papadeas <35376950+OverloadedOrama@users.noreply.github.com> Co-authored-by: ballerburg9005 <50874674+ballerburg9005@users.noreply.github.com> Co-authored-by: ballerburg9005 <mathias.steiger@gmail.com> Co-authored-by: DragonOfWar <47753585+DragonOfWar@users.noreply.github.com> Co-authored-by: DragonOfWar <47753585+KawanWeege@users.noreply.github.com> Co-authored-by: kevinms <ksmith.nop@gmail.com> Co-authored-by: Martin Novák <42614907+novhack@users.noreply.github.com> Co-authored-by: Darshan Phaldesai <51489635+luiq54@users.noreply.github.com> Co-authored-by: Xenofon Konitsas <38171523+huskeee@users.noreply.github.com>
Added ability to set project name also fixed a bug that "if the aspect ratio button is pressed and a template of different width and height were selected, then the button also applied on them e.g a template of (but it shouldn't)" Example: write 1 in width, 2 in height, enable asspect ratio, and then try to change template... a template of 256x240 will give 120x240
fixed tag behavior in "Project.gd"
fixed tag behavior in "AnimationTimeline.gd"
fix top part of line not visible
a fix i forgot about earlier
... to auto select colors of new tags
src/UI/Timeline/FrameTagDialog.gd
Outdated
| @@ -65,6 +65,8 @@ func _on_AddTag_pressed() -> void: | |||
| current_tag_id = Global.current_project.animation_tags.size() | |||
| options_dialog.get_node("GridContainer/FromSpinBox").value = Global.current_project.current_frame + 1 | |||
| options_dialog.get_node("GridContainer/ToSpinBox").value = Global.current_project.current_frame + 1 | |||
| randomize() | |||
There was a problem hiding this comment.
randomize() is not needed here. It's already called in the first line of Global's _ready() method and it should only be called once at the start of the project.
There was a problem hiding this comment.
Oh, i didn't know!. Okay, i removed it.
OverloadedOrama
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR contains;
Before:
After:
