Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish context menu - pixelorama.nsi #972

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Polish context menu - pixelorama.nsi #972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions installer/pixelorama.nsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
; Helper variables so that we don't change 20 instances of the version for every update

!define APPNAME "Pixelorama"
!define APPVERSION "v0.11.2"
!define APPVERSION "v0.11.3"
!define COMPANYNAME "Orama Interactive"


Expand Down Expand Up @@ -81,7 +81,7 @@

; Multilingual support

!insertmacro MUI_LANGUAGE "English"
!insertmacro MUI_LANGUAGE "Polski"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks incorrect to me, it seems to be replacing English with Polish rather than adding it as a new translation. I'm not entirely familiar with how .nsi files work so I'm not sure what the correct solution is here.

;@INSERT_TRANSLATIONS@


Expand Down Expand Up @@ -152,7 +152,7 @@
WriteRegStr HKCR "Pixelorama project\DefaultIcon" "" "$INSTDIR\pxo.ico"

WriteRegStr HKCR "Pixelorama project\shell\open\command" "" '$INSTDIR\${APPNAME}.exe "%1"'
WriteRegStr HKCR "Pixelorama project\shell\edit" "" "Edit project in ${APPNAME}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the file I sent, there is a Polish version of the context menu on line 155. Should I add a new file
Screenshot_2024-01-11-15-38-07-831_com android chrome
called pixelorama-pl.nsl?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a mistake, I could have added it immediately as a new file and added PR. Sorry, I'm still learning Github. I sent the correct (I hope) PR.

WriteRegStr HKCR "Pixelorama project\shell\edit" "" "Edytuj projekt w ${APPNAME}"
WriteRegStr HKCR "Pixelorama project\shell\edit\command" "" '$INSTDIR\${APPNAME}.exe "%1"'
SectionEnd

Expand Down