Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buttons + pagination with dark mode #2266

Closed
2 tasks done
Dorian-Grim opened this issue Sep 25, 2023 · 1 comment
Closed
2 tasks done

buttons + pagination with dark mode #2266

Dorian-Grim opened this issue Sep 25, 2023 · 1 comment

Comments

@Dorian-Grim
Copy link

Dorian-Grim commented Sep 25, 2023

Related PR #2223

Prerequisites

Proposal

  • data-bs-theme to work with button component
    Current behavior
    tu
    How they should look like on dark
    image

  • data-bs-theme to work with pagination component too
    Current look on dark enabled
    image

How it should look like
image

Motivation and context

Fully use data-bs-theme

@julien-deramond
Copy link
Member

Thanks for opening this issue @Dorian-Grim
The first part of the dark mode is available in the framework but not yet to be used by Orange projects because it has not yet been implemented in terms of Orange rendering.
We are currently working on it and the full dark mode will be available in one of the next Boosted releases.
Based on your description, all components (such as buttons) will be tackled in #2223.
You can subscribe to this PR if you're interested to see how things go on.
Closing this issue as already identified in #2223.

@julien-deramond julien-deramond closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants